MagicMirror Forum

    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • Donate
    • Discord
    MagicMirror² v2.20.0 is available! For more information about this release, check out this topic.

    Alert module display_time

    Bug Hunt
    3
    4
    2428
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Pieps
      Pieps last edited by

      Hi @MichMich ,

      I just wanted to tell you that there is a fault in the config part of your readme of the alert module.

      The display time is described in seconds but its really expressed in milliseconds. So on default, the alert is shown for 3.5ms … nothing 😉

      I’m sure that a lot of the users did found this by herself, but for the noobs it could be confusion.

      Best wishes
      Pieps

      MichMich 1 Reply Last reply Reply Quote 0
      • MichMich
        MichMich Admin @Pieps last edited by

        @Pieps Feel free to send a PR with the fix. Or if that’s too difficult, feel free to point me to the right file containing the error (+ line number). I’ll fix is.

        Thanks!

        strawberry 3.141 1 Reply Last reply Reply Quote 0
        • strawberry 3.141
          strawberry 3.141 Project Sponsor Module Developer @MichMich last edited by

          @MichMich https://github.com/MichMich/MagicMirror/tree/master/modules/default/alert in the readme it says seconds but the implementation is based on milliseconds

          Please create a github issue if you need help, so I can keep track

          1 Reply Last reply Reply Quote 0
          • MichMich
            MichMich Admin last edited by

            Fixed: https://github.com/MichMich/MagicMirror/blob/develop/modules/default/alert/README.md

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            • First post
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Paul-Vincent Roll and Rodrigo Ramírez Norambuena.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy