const exec = require('child_process').exec
var NodeHelper = require("node_helper")

module.exports = NodeHelper.create({
  socketNotificationReceived: function(noti, payload) {
    if (noti == "GIVE_ME_RESULT") {
      setTimeout(()=>{
        exec("C:\WINDOWS\system32\get-temperature", //I don't know WINDOWS system at all. Is it right?
          (err, sto, ste) => {
            if (!err) {
              this.sendSocketNotification("HERE_IS_RESULT", sto)
            } else {
              console.log("Error", err)
            }
          }
        )
      }, 1000)
    }
  }
})

It isn’t tested. But you can catch the idea.

How often do u need to get the temps?
Is it on a timer, or some other mechanism?

Anyhow, on that cycle, you would issue the ‘run’ of the powershell app in the node_helper.js, and capture it’s output.

Then process the output, remove all the useless data. Then send the raw data to the module.js, who will then format the HTML in the get_dom() function for display

Yes, that is the command to get the temps from the PC using powershell or command prompt…

BUT, where to use the command in node_helper.js?

OR, where to use the command in the module.js file?

Not sure I follow …

what would be my ‘shell command’?

exec(“YOUR-SHELL-COMMAND”, (error, stdout, stderr)=>{
  console.log(stdout)
  // do your job with `stdout`
})

I think you can get the result of any execution of shell script.

What are the chances of being able to do what I had been attempting with this?
https://github.com/moxystudio/node-cross-spawn

And would it be possible to add to a current node_helper being used for linux, or would a separate node_helper or script need made?

I had a syntax error in the declaration of Temps.

I’m totally thinking this isn’t going to work.

I will probably need to find a different way,
figured if I could pull it from the SIMBIOS using a simple script, that maybe it could be pulled using a module for MM.

there are some open source apps for Windows that work to get the data, I will just have to study them and see what I can come up with.

Thanks for trying to help.

I defined Temps. then got this in console…

MMM-PC-Stats.js:104 Uncaught (in promise) TypeError: Cannot read property '
ootwmi:MSAcpi_ThermalZoneTemperature' of undefined
    at Class.getDom (MMM-PC-Stats.js:104)
    at main.js:110
    at new Promise (<anonymous>)
    at updateDom (main.js:109)
    at Object.updateDom (main.js:514)
    at Class.updateDom (module.js:358)
    at Class.socketNotificationReceived (MMM-PC-Stats.js:213)
    at module.js:246
    at r.<anonymous> (socketclient.js:25)
    at r.emit (index.js:133)

It seems like you’re trying to do the ui before you have the data.

it throws this error…

Uncaught (in promise) ReferenceError: Temps is not defined
    at Class.getDom (MMM-PC-Stats.js:103)
    at main.js:110
    at new Promise (<anonymous>)
    at updateDom (main.js:109)
    at Object.updateDom (main.js:514)
    at Class.updateDom (module.js:358)
    at Class.socketNotificationReceived (MMM-PC-Stats.js:218)
    at module.js:246
    at r.<anonymous> (socketclient.js:25)
    at r.emit (index.js:133)

this script ran in powershell …

function Get-Temperature {
    $t = Get-WmiObject MSAcpi_ThermalZoneTemperature -Namespace "root/wmi"
    $returntemp = @()

    foreach ($temp in $t.CurrentTemperature)
    {
        $currentTempKelvin = $temp / 10
        $currentTempCelsius = $currentTempKelvin - 273.15
        $currentTempFahrenheit = (9/5) * $currentTempCelsius + 32
        $returntemp += $currentTempCelsius.ToString() + " C : " + $currentTempFahrenheit.ToString() + " F : " + $currentTempKelvin + "K"  
    }
    return $returntemp
}

gives the following output for a single core …

PS C:\WINDOWS\system32> get-temperature
44.05 C : 111.29 F : 317.2K

I’m really only interested in a C and F result, no need for K that I can think of.

PS C:\WINDOWS\system32> powershell.exe Get-WmiObject MSAcpi_ThermalZoneTemperature -Namespace "root/wmi"


__GENUS              : 2
__CLASS              : MSAcpi_ThermalZoneTemperature
__SUPERCLASS         : MSAcpi
__DYNASTY            : MSAcpi
__RELPATH            : MSAcpi_ThermalZoneTemperature.InstanceName="ACPI\\ThermalZone\\THRM_0"
__PROPERTY_COUNT     : 12
__DERIVATION         : {MSAcpi}
__SERVER             : DESKTOP-BEUARKC
__NAMESPACE          : root\wmi
__PATH               : \\DESKTOP-BEUARKC\root\wmi:MSAcpi_ThermalZoneTemperature.InstanceName="ACPI\\ThermalZone\\THRM_0
                       "
Active               : True
ActiveTripPoint      : {0, 0, 0, 0...}
ActiveTripPointCount : 0
CriticalTripPoint    : 3762
CurrentTemperature   : 3172
InstanceName         : ACPI\ThermalZone\THRM_0
PassiveTripPoint     : 3882
Reserved             : 0
SamplingPeriod       : 100
ThermalConstant1     : 2
ThermalConstant2     : 10
ThermalStamp         : 25
PSComputerName       : DESKTOP-BEUARKC

var checkSensorTemps = Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"];
if (typeof checkSensorTemps !== "undefined") {

	// Core Temps
	var core0Temp = document.createElement("div");
	core0Temp.classList.add("large", "bright", "core0Temp");
	core0Temp.innerHTML = Stats.cpu.threads[i].name + " &nbsp  @  &nbsp " 
		+ ((Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value / 10) -273.15) + " °C "
		+ ((((Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value / 10) -273.15) * 9/5) + 32) + " °F "
		+ (Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value  / 10) + "°K";
	wrapper.appendChild(core0Temp);
}

HELP! LMAO! :face_with_stuck-out_tongue_winking_eye:

getTemperature: function() {
	var t = getWmiObject = MSAcpi_ThermalZoneTemperature(Namespace = "root/wmi" | where (Property = instancename) && (EQ = "ACPI\ThermalZone\TZ01_0"));
	currentTempKelvin = t.CurrentTemperature / 10;
	currentTempCelsius = currentTempKelvin - 273.15;
	currentTempFahrenheit = (9/5) * currentTempCelsius + 32;		
	return currentTempCelsius + " C " + currentTempFahrenheit + " F : " + currentTempKelvin + "K";
},

I’m pretty sure rest of the function is ok. But, I could be wrong! :disappointed_face:

yeah, sorry, I see some of the errors, but not all of them.

Want to hint me a little?