SOLVED All Souls Day is displayed 1 day late.

Tribun

Hi folks, when I enter the holidays from Apple in the calendar module, All Souls Day is displayed 1 day too late. All Saints ‘Day is displayed in 6 days, All Souls’ Day in 8 days.
The day is displayed correctly on the Ipad and the Iphone.
I’m using the developer branch.

DTSTART;VALUE=DATE:20201102
CLASS:PUBLIC
SUMMARY;LANGUAGE=de-AT:Allerseelen
TRANSP:TRANSPARENT
CATEGORIES:Feiertag
X-APPLE-UNIVERSAL-ID:4b6d2f05-680e-7b5e-043f-8cbd2ad082c0
END:VEVENT
BEGIN:VEVENT
DTSTAMP:20171204T190108Z

https://p39-calendars.icloud.com/holidays/at_de.ics

sdetweil

@Tribun its because the cal entry doesn’t have an end date (DTEND: record)
I have found a storage corruption… resetting the end whacks the start date value…

sdetweil

@Tribun wanna try a fix for me?

edit the ~/MagicMirror/modules/default/calendar/calendarfetcher.js, approx line 118

					if (typeof event.end !== "undefined") {
						endDate = eventDate(event, "end");
					} else if (typeof event.duration !== "undefined") {
						endDate = startDate.clone().add(moment.duration(event.duration));
					} else {
						if (!isFacebookBirthday) {
                                                        endDate = startDate           // change from this
							endDate = moment(startDate.format("x"),'x')    // to this

sdetweil

@Tribun I have submitted fix for this
https://github.com/MichMich/MagicMirror/pull/2178

Tribun

@sdetweil Thanks for the fix, now it is displayed correctly.