• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

GIT and updates to Weather Module

Scheduled Pinned Locked Moved Development
5 Posts 3 Posters 866 Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • C Offline
    crazylegs
    last edited by Feb 19, 2021, 4:53 PM

    Hello! I just need a sanity-check from the smart people on this forum to make sure I understand what I’m doing:

    I’ve built/tested a new Provider for the (new) default weather module. This Provider allows the use of Environment Canada current/forecast weather data on MM. My code also requires a few small tweaks to existing code in the weather module.

    While I’m an (ahem) older Developer, I don’t have a ton of experience with Github, so I just want to make sure I understand the steps to submit my updates to the default weather module. Here’s my understanding of things:

    1. Fork my own copy of the MagicMirror repository into my Github account.

    2. Make my changes - i.e. update the existing modules that need changes plus add my new Provider code

    3. For each module a I change, I need to Commit to the master branch (assuming this is the master for my own forked copy of MM repository)

    4. Once I have made/committed all my changes, I create a Pull Request that outlines what I have done. I assume a single PR will cover all the scripts I am touching?

    5. The PR will be assessed, with maybe questions asked, additional updates requested, whatever. If accepted, my changes in my MM repository will be merged into the main MM repository

    Do I have all this right? Sorry for the newbie questions - just new to this stuff and don’t want to screw up.

    Thanks!

    S 1 Reply Last reply Feb 19, 2021, 5:49 PM Reply Quote 0
    • S Offline
      sdetweil @crazylegs
      last edited by Feb 19, 2021, 5:49 PM

      @crazylegs almost correct steps.

      the fork is the key, now u have your copy to.modify

      make your own branch for changes

      on master branch (git branch has *next to master)

      git checkout -b your_new_branch_name

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      K 1 Reply Last reply Feb 19, 2021, 7:47 PM Reply Quote 0
      • K Offline
        karsten13 @sdetweil
        last edited by Feb 19, 2021, 7:47 PM

        2 more things:

        • the new branch you are using should start on the mm-branch develop (not master)
        • when creating the PR on github you have to manually change the base branch from master to develop

        These rules are specific to the mm-repo. Because of quarterly releases the master branch only changes 4 times in a year. The development between the releases is done on develop.

        S 1 Reply Last reply Feb 19, 2021, 9:18 PM Reply Quote 1
        • S Offline
          sdetweil @karsten13
          last edited by Feb 19, 2021, 9:18 PM

          @karsten13 thanks forgot develop again!!

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          C 1 Reply Last reply Feb 20, 2021, 2:13 PM Reply Quote 0
          • C Offline
            crazylegs @sdetweil
            last edited by Feb 20, 2021, 2:13 PM

            @sdetweil @karsten13

            Thank you both so much for your guidance! It is much appreciated and I believe I understand what I need to do.

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            1 / 1
            • First post
              1/5
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy