Goggle Calendar (iCal) event displaying incorrect time (offset by TimeZone amount (-11 hours))

RustyKnight · Dec 20, 2021, 10:47 PM

Platform: Raspberry Pi 4 Model B Rev 1.4 8gb
Node Version: v14.18.2
MagicMirror Version: v2.17.1
Description…
I added a couple of Google Calendar private iCal URLs to the Calendar module

{
	module: "calendar",
	header: "",
	position: "top_left",
	hideTime: true,
	config: {
		fullDayEventDateFormat: "MMM Do",
		calendars: [
			{
				symbol: "...",
				url: "https://calendar.google.com/calendar/ical/.../private-.../basic.ics"
			},
			{
				symbol: "...",
				url: "https://calendar.google.com/calendar/ical/.../private-.../basic.ics"
			},
			{
				symbol: "",
				url: "https://www.vic.gov.au/sites/default/files/2021-09/Victorian-public-holiday-dates.ics"
			},
			{
				symbol: "clock",
				url: "https://www.vic.gov.au/sites/default/files/2021-03/Daylight-saving.ics"
			}
		]
	}
},

(fyi, the source of the issue is from the second private calendar, but I’ll provide some more details below)

When running MM, the event

BEGIN:VEVENT
DTSTART;TZID=Australia/Melbourne:20211107T090000
DTEND;TZID=Australia/Melbourne:20211107T100000
RRULE:FREQ=WEEKLY
DTSTAMP:20211220T212053Z
UID:C888BE5E-B3FC-442C-B900-44D2DF7E9C6D
CREATED:20211028T062118Z
DESCRIPTION:
LAST-MODIFIED:20211028T062118Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:Teagan: K6 Sunday 9:30:00
TRANSP:OPAQUE
END:VEVENT

is displayed -11 hours (ie the day before @ 2200 instead of 0900), all other events (so far) from the same calendar are been presented correctly

*nb: K6 should be Sunday 09:00, living in Australia/Melbourne Daylight Savings Time, +11)

Google iCal preamble:

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
X-WR-CALNAME:gin.no.tonbo@gmail.com
X-WR-TIMEZONE:Australia/Sydney
BEGIN:VTIMEZONE
TZID:Australia/Sydney
X-LIC-LOCATION:Australia/Sydney
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:AEST
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:AEDT
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VTIMEZONE
TZID:Australia/Melbourne
X-LIC-LOCATION:Australia/Melbourne
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:AEST
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:AEDT
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VTIMEZONE
TZID:Australia/Hobart
X-LIC-LOCATION:Australia/Hobart
BEGIN:DAYLIGHT
TZOFFSETFROM:+1000
TZOFFSETTO:+1100
TZNAME:AEDT
DTSTART:19701004T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+1100
TZOFFSETTO:+1000
TZNAME:AEST
DTSTART:19700405T030000
RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=1SU
END:STANDARD
END:VTIMEZONE

Thinking I had screwed something up, I download a copy of the iCal file from Google and run it through another library (biweekly Java Library) and had no issues

sdetweil · Dec 20, 2021, 11:17 PM

@rustyknight said in Goggle Calendar (iCal) event displaying incorrect time (offset by TimeZone amount (-11 hours)):

download a copy of the iCal file from Google and run it through another library (biweekly Java Library) and had no issues

cool , but we don’t have any Java code in mm.

all volunteer written

sdetweil · Dec 20, 2021, 11:19 PM

@rustyknight we don’t use the preamble

can u show two events. one good, one bad

RustyKnight · Dec 21, 2021, 10:32 PM

@sdetweil Yes, I figured that, but my experience is in Java and Swift, so I went for what I had and just wanted to see if it was an issue with the source data ;)

RustyKnight · Dec 21, 2021, 10:36 PM

@sdetweil

That’s the 945 event

BEGIN:VEVENT
DTSTART:20211222T224500Z
DTEND:20211222T234500Z
DTSTAMP:20211221T223311Z
UID:2543FA59-A330-461F-80E8-1C063DA368A6
CREATED:20211219T213900Z
DESCRIPTION:
LAST-MODIFIED:20211219T213900Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:9.45 Dr Linley
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P0DT1H0M0S
END:VALARM
END:VEVENT

And the bins out (repeating event)

BEGIN:VEVENT
DTSTART;TZID=Australia/Sydney:20190205T160000
DTEND;TZID=Australia/Sydney:20190205T161500
EXDATE;TZID=Australia/Sydney:20190205T160000
EXDATE;TZID=Australia/Sydney:20190212T160000
EXDATE;TZID=Australia/Sydney:20190219T160000
EXDATE;TZID=Australia/Sydney:20190226T160000
EXDATE;TZID=Australia/Sydney:20190305T160000
EXDATE;TZID=Australia/Sydney:20190312T160000
EXDATE;TZID=Australia/Sydney:20190319T160000
EXDATE;TZID=Australia/Sydney:20190326T160000
EXDATE;TZID=Australia/Sydney:20190402T160000
EXDATE;TZID=Australia/Sydney:20190409T160000
EXDATE;TZID=Australia/Sydney:20190416T160000
EXDATE;TZID=Australia/Sydney:20190423T160000
EXDATE;TZID=Australia/Sydney:20190430T160000
EXDATE;TZID=Australia/Sydney:20190507T160000
EXDATE;TZID=Australia/Sydney:20190514T160000
EXDATE;TZID=Australia/Sydney:20190521T160000
EXDATE;TZID=Australia/Sydney:20190528T160000
EXDATE;TZID=Australia/Sydney:20190604T160000
EXDATE;TZID=Australia/Sydney:20190611T160000
EXDATE;TZID=Australia/Sydney:20190618T160000
EXDATE;TZID=Australia/Sydney:20190625T160000
EXDATE;TZID=Australia/Sydney:20190702T160000
EXDATE;TZID=Australia/Sydney:20190709T160000
EXDATE;TZID=Australia/Sydney:20190716T160000
EXDATE;TZID=Australia/Sydney:20190723T160000
EXDATE;TZID=Australia/Sydney:20190730T160000
EXDATE;TZID=Australia/Sydney:20190806T160000
EXDATE;TZID=Australia/Sydney:20190813T160000
EXDATE;TZID=Australia/Sydney:20190820T160000
EXDATE;TZID=Australia/Sydney:20190827T160000
EXDATE;TZID=Australia/Sydney:20190903T160000
EXDATE;TZID=Australia/Sydney:20190910T160000
EXDATE;TZID=Australia/Sydney:20190917T160000
EXDATE;TZID=Australia/Sydney:20190924T160000
EXDATE;TZID=Australia/Sydney:20191001T160000
EXDATE;TZID=Australia/Sydney:20191008T160000
EXDATE;TZID=Australia/Sydney:20191015T160000
EXDATE;TZID=Australia/Sydney:20191022T160000
EXDATE;TZID=Australia/Sydney:20191029T160000
EXDATE;TZID=Australia/Sydney:20191105T160000
EXDATE;TZID=Australia/Sydney:20191112T160000
EXDATE;TZID=Australia/Sydney:20191119T160000
EXDATE;TZID=Australia/Sydney:20191126T160000
EXDATE;TZID=Australia/Sydney:20191203T160000
EXDATE;TZID=Australia/Sydney:20191210T160000
EXDATE;TZID=Australia/Sydney:20191217T160000
EXDATE;TZID=Australia/Sydney:20191224T160000
EXDATE;TZID=Australia/Sydney:20191231T160000
EXDATE;TZID=Australia/Sydney:20200107T160000
EXDATE;TZID=Australia/Sydney:20200114T160000
EXDATE;TZID=Australia/Sydney:20200121T160000
EXDATE;TZID=Australia/Sydney:20200128T160000
EXDATE;TZID=Australia/Sydney:20200204T160000
EXDATE;TZID=Australia/Sydney:20200211T160000
EXDATE;TZID=Australia/Sydney:20200218T160000
EXDATE;TZID=Australia/Sydney:20200225T160000
EXDATE;TZID=Australia/Sydney:20200303T160000
EXDATE;TZID=Australia/Sydney:20200310T160000
EXDATE;TZID=Australia/Sydney:20200317T160000
EXDATE;TZID=Australia/Sydney:20200324T160000
EXDATE;TZID=Australia/Sydney:20200331T160000
EXDATE;TZID=Australia/Sydney:20200407T160000
EXDATE;TZID=Australia/Sydney:20200414T160000
EXDATE;TZID=Australia/Sydney:20200421T160000
EXDATE;TZID=Australia/Sydney:20200428T160000
EXDATE;TZID=Australia/Sydney:20200505T160000
EXDATE;TZID=Australia/Sydney:20200512T160000
EXDATE;TZID=Australia/Sydney:20200519T160000
EXDATE;TZID=Australia/Sydney:20200526T160000
EXDATE;TZID=Australia/Sydney:20200602T160000
EXDATE;TZID=Australia/Sydney:20200609T160000
EXDATE;TZID=Australia/Sydney:20200616T160000
EXDATE;TZID=Australia/Sydney:20200623T160000
EXDATE;TZID=Australia/Sydney:20200630T160000
EXDATE;TZID=Australia/Sydney:20200707T160000
EXDATE;TZID=Australia/Sydney:20200714T160000
EXDATE;TZID=Australia/Sydney:20200721T160000
EXDATE;TZID=Australia/Sydney:20200728T160000
EXDATE;TZID=Australia/Sydney:20200804T160000
EXDATE;TZID=Australia/Sydney:20200811T160000
EXDATE;TZID=Australia/Sydney:20200818T160000
EXDATE;TZID=Australia/Sydney:20200825T160000
EXDATE;TZID=Australia/Sydney:20200901T160000
EXDATE;TZID=Australia/Sydney:20200908T160000
EXDATE;TZID=Australia/Sydney:20200915T160000
EXDATE;TZID=Australia/Sydney:20200922T160000
EXDATE;TZID=Australia/Sydney:20200929T160000
EXDATE;TZID=Australia/Sydney:20201006T160000
EXDATE;TZID=Australia/Sydney:20201013T160000
EXDATE;TZID=Australia/Sydney:20201020T160000
EXDATE;TZID=Australia/Sydney:20201027T160000
EXDATE;TZID=Australia/Sydney:20201103T160000
EXDATE;TZID=Australia/Sydney:20201110T160000
EXDATE;TZID=Australia/Sydney:20201117T160000
EXDATE;TZID=Australia/Sydney:20201124T160000
EXDATE;TZID=Australia/Sydney:20201201T160000
EXDATE;TZID=Australia/Sydney:20201208T160000
EXDATE;TZID=Australia/Sydney:20201215T160000
EXDATE;TZID=Australia/Sydney:20201222T160000
EXDATE;TZID=Australia/Sydney:20210105T160000
EXDATE;TZID=Australia/Sydney:20210119T160000
EXDATE;TZID=Australia/Sydney:20210126T160000
EXDATE;TZID=Australia/Sydney:20210202T160000
EXDATE;TZID=Australia/Sydney:20210209T160000
EXDATE;TZID=Australia/Sydney:20210302T160000
EXDATE;TZID=Australia/Sydney:20210309T160000
EXDATE;TZID=Australia/Sydney:20210406T160000
EXDATE;TZID=Australia/Sydney:20210413T160000
EXDATE;TZID=Australia/Sydney:20210420T160000
EXDATE;TZID=Australia/Sydney:20210427T160000
EXDATE;TZID=Australia/Sydney:20210504T160000
EXDATE;TZID=Australia/Sydney:20210518T160000
EXDATE;TZID=Australia/Sydney:20210525T160000
EXDATE;TZID=Australia/Sydney:20210601T160000
EXDATE;TZID=Australia/Sydney:20210608T160000
EXDATE;TZID=Australia/Sydney:20210615T160000
EXDATE;TZID=Australia/Sydney:20210622T160000
EXDATE;TZID=Australia/Sydney:20210629T160000
EXDATE;TZID=Australia/Sydney:20210720T160000
EXDATE;TZID=Australia/Sydney:20210727T160000
EXDATE;TZID=Australia/Sydney:20210803T160000
EXDATE;TZID=Australia/Sydney:20210810T160000
EXDATE;TZID=Australia/Sydney:20210817T160000
EXDATE;TZID=Australia/Sydney:20210824T160000
EXDATE;TZID=Australia/Sydney:20211116T160000
EXDATE;TZID=Australia/Sydney:20211130T160000
EXDATE;TZID=Australia/Sydney:20211207T160000
EXDATE;TZID=Australia/Sydney:20211214T160000
EXDATE;TZID=Australia/Sydney:20211228T160000
EXDATE;TZID=Australia/Sydney:20220104T160000
RRULE:FREQ=WEEKLY
DTSTAMP:20211221T223311Z
UID:fhebaqcm1q4si46p3dbi0fkar8@google.com
CREATED:20181008T052126Z
DESCRIPTION:
LAST-MODIFIED:20211214T203247Z
LOCATION:
SEQUENCE:2
STATUS:CONFIRMED
SUMMARY:Bins out 
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P0DT1H0M0S
END:VALARM
BEGIN:VALARM
ACTION:NONE
TRIGGER;VALUE=DATE-TIME:19760401T005545Z
END:VALARM
END:VEVENT

sdetweil · Dec 21, 2021, 11:47 PM

@rustyknight im pretty sure the k6 problem is caused by the repeating rule.

the rule engine we use assumes start date/time is in local time format not utc.
everything else is utc,
so there is a double conversion cause it takes the date from one and time from another…

I also assume your system time is set to Melbourne…

RustyKnight · Dec 24, 2021, 7:37 PM

@sdetweil Yes, I went through all the PI settings and made sure they are set to Melbourne.

I’m not overly concerned about as I’m only testing this stuff out, my wife will have whinge though 🙄

sdetweil · Dec 24, 2021, 7:37 PM

@rustyknight i found the problem in the calendar module a while back #2632) and have submitted a fix for the next release, Jan 1.

https://github.com/MichMich/MagicMirror/pull/2748/

which hasbeen accepted and merged…

if u want to test it now, you can do this
https://forum.magicmirror.builders/topic/14327/testing-new-fixes-or-solving-current-problems-with-next-release-code