MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-AVStock not loading quotes

    Scheduled Pinned Locked Moved Solved Troubleshooting
    11 Posts 3 Posters 208 Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      scottwalsh @ArnoldoB
      last edited by

      @ArnoldoB
      Is it still working? I see your pull request is before the version of yahoofinance that made the user agent changes a couple of days ago.

      A 1 Reply Last reply Reply Quote 0
      • A Offline
        ArnoldoB @scottwalsh
        last edited by

        @scottwalsh I’m not sure. I haven’t tried since last month. Yahoo_finance API is a moving target. I’ve been busy writing my own stock, crypto and forex module after yahoo_finance2 last annoyed me.

        S 1 Reply Last reply Reply Quote 0
        • S Offline
          scottwalsh @ArnoldoB
          last edited by

          @ArnoldoB

          The fork you created doesn’t resolve it, also needed to use the new function to set the user agent.

          Was able to build on the branch you created for v3 support and get it working.

          In summary:
          Forked your branch
          Upgraded yahoo finance to the latest version (3.11.2).
          Update MMM-AVStock to use the new user agent function (^3.11.2)

          Looks like all fixed.

          Will give it a day or two and it looks fine will submit a pull request.

          A 1 Reply Last reply Reply Quote 1
          • A Offline
            ArnoldoB @scottwalsh
            last edited by

            @scottwalsh I’m glad my little fix was helpful in finding a solution.

            S 1 Reply Last reply Reply Quote 0
            • S Offline
              scottwalsh @ArnoldoB
              last edited by

              @ArnoldoB
              Submitted a pull request to the upstream.

              1 Reply Last reply Reply Quote 0
              • S scottwalsh has marked this topic as solved
              • 1
              • 2
              • 1 / 2
              • First post
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy