MMM-Slack stop randomise messages

gekberlin

@saibam That sounds pretty good. I wanted to achive the same for the last 5 messages. So i would simpley exchange the 10 for a 5. But where do I have to put the code into ? In the mmm-slack.js ?
I would relay appreciate any help.

saibam

@gekberlin Yes. Change maxAllowed to 5. Put it in MMM-Slack.js under the getDom: function() where it creates the html elements. I also noticed that it didnt work as expected where I had (maxCount -1) and (maxAllowed - 1). I removed the -1 and it worked like a charm.

gekberlin

@saibam Thanks for your fast reply!
I’ve put in the code but then I didn’t get any message displayed anymore.
Did I have done something wrong ?

	getDom: function() {
		var messageElement = document.createElement('div');
		if (currentMessageCount < this.slackMessages.length || currentMessageCount == 0){
	currentMessageId = 0;
	currentMessageCount = this.slackMessages.length;
}
var maxAllowed = 5;
var topMessages = this.slackMessages.slice(0, (maxAllowed 0));
var maxCount = Math.min(maxAllowed, topMessages.length);
if (currentMessageId == maxCount 0) { currentMessageId = 0; }
var currentMessage = topMessages[currentMessageId].message;
currentMessage = emoji_replace(currentMessage);
messageElement.innerHTML = currentMessage;
currentMessageId ++;
		}
		return messageElement;
	}
});

saibam

@gekberlin Yes.

currentMessage = emoji_replace(currentMessage);

will not work as emoji_replace is my own function for replacing :smiley: with an emoji.
so just get rid of that line and it will work.

And you will also have to instantiate currentMessageId and currentMessageCount globally. I.e.

var currentMessageId = 0
var currentMessageCount = 0

at the top of the js file.

mediathreat

@saibam Which Slack token do you use to connect to slack and do you have to put the leading # hash sign in the config file for the channel where it listens?

saibam

@mediathreat we followed the link in the readme https://api.slack.com/tokens and from there we created our own app. I’m sorry I can’t find where I found the token in there, you will have to try and error your way :) I will keep looking some but can’t guarantee I find anything. Slack API pages are a mess imo. And no you don’t need the leading # in the config file.

saibam

@mediathreat here is the correct link to create your token: https://api.slack.com/custom-integrations/legacy-tokens

mediathreat

Thanks! This nailed it perfectly! Hopefully the MMM-SLACK package maintainer might add this info to be clearer. Now that I have it working, I wonder if I can go in and see if I can add showing photos from a slack channel to the code base

mediathreat

@saibam do you think its possible to modify the code to get images or links that are posted into the slack channel and display them on the magic mirror?

saibam

@mediathreat I think it is possible, as long as the images have some kind of html address or similar, but I have no idea how to do it. I’ve moved on to other projects now :) almost finished an arcade cabinet :D