Read the statement by Michael Teeuw here.
External Compliments list limitations and randomness
-
@Anhalter42 I knew this guy and he was having a problem with git checkout develop because when he did that it said error: your local changes to compliments.js would be overwritten and then it said Aborting.
-
@RE_Magic_Mirror “this guy” probably made some changes to the compliments.js file. If you didn’t do any changes to the source code itself, then changing branches (like updating MM) should be a piece of cake. You don’t lose anything by trying. Either it doesn’t work and doesn’t change anything (“aborting”) or you can change back at anytime (
git checkout master,git pull).Btw, what do you mean by “seems to break it” when talking about the larger list?
-
@Anhalter42 I think the only changes to the compliments.js would be the location of the remote file, I think there was just the issue because it automatically aborted git checkout master because of that error. But putting a stock compliments.js file in the directory and then git checkout master, get pull gave an already updated message.
What I meant is I when i used the full size list it would only display the stock compliments but reduced list in the remote file work.
I basically debugged the problem by adding compliments to the remote file in chunks until I was satisfied with the amount. It seems to be working now with about 115 compliments per morning, afternoon, evening. I think i am going to call that a victory and move on to the next project. PIR alexa and sound reactive led.
Thank you for your help.
-
@RE_Magic_Mirror maybe there was a comma missing somewhere in the large amount of lines (sometimes not easy to spot). Good to hear you got it to work properly.
One more note: you should never need to do changes to compliments.js (or any other source code file). Like for (nearly) every module, it should be sufficient to change the config file (and sometimes extra remote files like for example the compliments file). In particular, the location of the external compliments file should be defined in the config file.
-
@Anhalter42 one thing that has come up, now at the top center of the MM screen a notification stating that there is a magicmirror update and I am 12 comments behind on the develop branch. What do I need to do to either stay updated or should i just (git checkout master, git pull)?
-
@RE_Magic_Mirror Well…it depends.
- If switching to develop branch fixed your problem, then you want to stay at develop until the changes are merged into the master branch. Until then, you can either update (see https://github.com/MichMich/MagicMirror#updating-your-magicmirror) or decide to ignore updates. If you don’t want to see the notification, you have to disable the update notification module.
- If it did not help with your problem, then you are usually better off using the master branch, so I would suggest to switch back to master.
