weatherforecast showing only two days.

erik.voznak

@lavolp3
I did update this morning and issue started after update…

[2020-07-02 13:37:30.638] [LOG] Starting MagicMirror: v2.12.0
[2020-07-02 13:37:30.651] [LOG] Loading config …

A Former User

This post is deleted!

oemel09

Had the same issue after the update.
The problem is, that the weatherforecast first checks the paid version of the API to get full day forecasts (https://api.openweathermap.org/data/2.5/forecast/daily?id=xxx&cnt=7&units=metric&lang=de&APPID=xxx)

This results in a 401 for me because I’m using a free API token.

Next the weatherforecast module falls back using the 5 day / 3 hour Forecast API by using the same cnt value (https://api.openweathermap.org/data/2.5/forecast?id=xxx&cnt=7&units=metric&lang=de&APPID=xxx). Here the value 7 for cnt returns 7 entries, that’s why there is only a two day forecast.

I’ll try to write a fix.
In the meantime as a quick fix you can change line 297 of weatherforecast.js from:

params += "&cnt=" + (this.config.maxNumberOfDays < 1 || this.config.maxNumberOfDays > 17 ? 7 : this.config.maxNumberOfDays);

to

params += "&cnt=" + (this.config.maxNumberOfDays < 1 || this.config.maxNumberOfDays > 5 ? 40 : this.config.maxNumberOfDays * 8);

Remeber the fallback API provides only a 5 day forecast, that’s why maxNumberOfDays is limited to 5.

erik.voznak

@hango, yeah I know I shouldn`t but I am using free API so… but anyway I will change appid.

@oemel09, Many thanks man, your fix helped and finally it is working as intended.

alt text

castletonroad

This fix worked for me too, so thanks very much.

Also, showRainAmount: “false” does not work - i still see mm rain forecast against each day.

This is all a little disappointing as up until the recent upgrade, ‘weatherforecast’ was working perfectly.

And BTW, in trying to resolve the problem with ‘weatherforecast’, before coming to this thread, I also tried the ‘weather’ module, the replacement for ‘currentweather’ and ‘weatherforecast’. I couldn’t get that to work in ‘forecast’ mode, only in ‘current’ mode. The module just displays ‘Loading…’.

Ho-hum…

sdetweil

@castletonroad

how about no quotes

showRainAmount: false,

values that are all numbers, or true and false do not need quotes
everything else does need quotes

castletonroad

@sdetweil Great, that sorted things nicely!

How ever did I miss that in the config instructions… :astonished_face:

tenyo

@oemel09 Thanks a lot!

dh1201

Thanks for the ‘quick fix’ - Works perfectly.

ArthurOff

Will this be fixed in the next update or do we need to adjust manually?