MMM-Calendar always shows 23:59 if showEndTime: True

sdetweil

can we try another quick fix?

in calendar.js

				// Define second, minute, hour, and day variables
				var oneSecond = 1000; // 1,000 milliseconds
				var oneMinute = oneSecond * 60;
				var oneHour = oneMinute * 60;
				var oneDay = oneHour * 24;
				if (event.fullDayEvent) {
					//subtract one second so that fullDayEvents end at 23:59:59, and not at 0:00:00 one the next day
					//event.endDate -= oneSecond;   < ---- comment out this one line

SwissChemist

@sdetweil
maybe you expected already that now the endTime of each whole day event is shown one day too late. Without that fix, it has been correct.

Regarding the ‘3-weekly whole day’ you gave me a perfect hint: As it is a user configured interval, you have to take care that begin of the event and day of the week you select as interval correspond. So if you configure it wrong, corresponding event will obviously not be shown, as you explained perfectly from your code analysis…

SwissChemist

@sdetweil
I would not mind to see 23:59 as end of a whole day event, but it would also be fine for me to see the day where it starts again…

sdetweil

@SwissChemist finding an acceptable “end” marker for “full day” event is challenging.

it certainly ends when the next day starts.

sdetweil

@SwissChemist can u look at this, your cal, in your timezone, 2.13 no modifications
showEnd:true,
maximumEntries:25,
2.13-german.png

SwissChemist

@sdetweil
It’s getting better and better, great!

The only event, which is not correct yet, ist the 3-weekly 13-14. This should be in 21 days (Oct 22nd), exactly like the 3-weekly whole day. The following ones could be better controlled in an absolute time format…

sdetweil

@SwissChemist no… that cal entry says wednesdays, so the 21st, rule wins on exact days, start/end win on time

BEGIN:VEVENT
CREATED:20200928T173453Z
DTEND;TZID=Europe/Zurich:20201001T140000
DTSTAMP:20200928T182743Z
DTSTART;TZID=Europe/Zurich:20201001T130000
LAST-MODIFIED:20200928T182742Z
RRULE:FREQ=WEEKLY;INTERVAL=3;BYDAY=WE  < -------
SEQUENCE:0
SUMMARY:3-weekly 13-14
UID:A7C8DBD0-0AA9-468B-A3F8-A5F97B797C11
URL;VALUE=URI:
END:VEVENT

SwissChemist

Ok, then it’s my error again. In the meantime I have corrected my calendar entry. Would you need a new calenendar export, or would you like to send me your fix to test it here?

sdetweil

@SwissChemist install/upgrade to 2.13, should fix it

https://github.com/sdetweil/MagicMirror_scripts

I changed cal entry to TH, now shows 21 days, on the 22nd

SwissChemist

@sdetweil

now I have corrected my calender entry, but I still cannot see same date for ‘3-weekly whole day’ and ‘3-weekly 13-14’.
Do you see same date for these events?
Any idea what I do wrong? Thx very much!