• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-Calendar always shows 23:59 if showEndTime: True

Scheduled Pinned Locked Moved Bug Hunt
51 Posts 4 Posters 15.2k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Away
    sdetweil
    last edited by Sep 28, 2020, 9:18 PM

    also, showEnd is a pain… technically the clock is day:00:00 to day 23:59 as 23:59+1 is 24:00/00:00 which is the next day

    so, what do you think we should be showing there…

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    S 1 Reply Last reply Sep 30, 2020, 7:40 PM Reply Quote 0
    • S Away
      sdetweil @SwissChemist
      last edited by sdetweil Sep 28, 2020, 10:17 PM Sep 28, 2020, 9:57 PM

      @SwissChemist want to try a fix for me…

      edited: changed added line

      edit the ~/MagicMirror/modules/default/calendar/calendarfetcher.js
      find this (approx line 240) and add the one line listed below

      						// Loop through the set of date entries to see which recurrences should be added to our event list.
      						for (let d in dates) {
      							const date = dates[d];
      							// ical.js started returning recurrences and exdates as ISOStrings without time information.
      							// .toISOString().substring(0,10) is the method they use to calculate keys, so we'll do the same
      							// (see https://github.com/peterbraden/ical.js/pull/84 )
      							const dateKey = date.toISOString().substring(0, 10);
      							let curEvent = event;
      							let showRecurrence = true;
      							let duration = 0;
      
      							startDate = moment(date);
      							duration = parseInt(moment(curEvent.end).format("x")) - parseInt(moment(curEvent.start).format("x")) // --- add this line
      

      in your timezone (mine is Sep 28, 17:15)

      Screenshot at 2020-09-29 00-14-48.png

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      1 Reply Last reply Reply Quote 0
      • S Offline
        SwissChemist
        last edited by SwissChemist Sep 29, 2020, 8:51 PM Sep 29, 2020, 8:42 PM

        Hello Sam,
        thanks very much for your great support.
        Good news is that the endTime issue is solved now!

        Nevertheless with recurring whole day events, the following entries are not correct yet:

        3-weekly 13-14 is completely missing (should be 1.Okt)

        Starting with the 3-weekly whole day 22.Okt (should be 21.Okt), every following ‘whole day meeting’ is shown one day too late.
        You can easily see that even on your picture, as e.g. the 3-weekly whole day and the 3-weekly 13-14 should always take place at the same date.

        Even on your picture this is not the case… monthly whole day is shown in 3 days, monthly 17-18 is shown in 4 days.

        Once more, thanks for your great support so far!
        ![0_1601412306493_MagicMirror_200929.JPG](Uploading 100%)

        1 Reply Last reply Reply Quote 0
        • S Away
          sdetweil
          last edited by Sep 29, 2020, 9:46 PM

          yeh, that whole day thing… the spec says its whole day in the timezone where the computer is.
          but the ical converter still adjusts it to UTC. (all parsed events are in UTC)

          3-weekly 13-14 is completely missing (should be 1.Okt)
          can’t be cause u asked for WEdnesdays

          
          BEGIN:VEVENT
          CREATED:20200928T173050Z
          DTEND;VALUE=DATE:20201002
          DTSTAMP:20200928T182733Z
          DTSTART;VALUE=DATE:20201001
          LAST-MODIFIED:20200928T182732Z
          RRULE:FREQ=WEEKLY;INTERVAL=3;BYDAY=WE  < ----
          SEQUENCE:0
          SUMMARY:3-weekly whole day
          UID:E2C82F47-1E0F-4FD0-93C4-746B2D53488B
          URL;VALUE=URI:
          END:VEVENT
          

          so , this repeating event might start on Oct 1, but thats a thursday, so will not be shown
          Screenshot at 2020-09-29 23-44-05.png

          but later, Starting with the 3-weekly whole day 22.Okt (should be 21.Okt),
          starts on 21+1 days from today 00:00:00 Oct 21, and ends on Oct 22

          this is a fix in the ical parser… so, it will take time to get out…

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          1 Reply Last reply Reply Quote 0
          • S Away
            sdetweil
            last edited by Sep 30, 2020, 4:25 PM

            can we try another quick fix?

            in calendar.js

            				// Define second, minute, hour, and day variables
            				var oneSecond = 1000; // 1,000 milliseconds
            				var oneMinute = oneSecond * 60;
            				var oneHour = oneMinute * 60;
            				var oneDay = oneHour * 24;
            				if (event.fullDayEvent) {
            					//subtract one second so that fullDayEvents end at 23:59:59, and not at 0:00:00 one the next day
            					//event.endDate -= oneSecond;   < ---- comment out this one line
            

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            S 1 Reply Last reply Sep 30, 2020, 7:32 PM Reply Quote 0
            • S Offline
              SwissChemist @sdetweil
              last edited by Sep 30, 2020, 7:32 PM

              @sdetweil
              maybe you expected already that now the endTime of each whole day event is shown one day too late. Without that fix, it has been correct.

              Regarding the ‘3-weekly whole day’ you gave me a perfect hint: As it is a user configured interval, you have to take care that begin of the event and day of the week you select as interval correspond. So if you configure it wrong, corresponding event will obviously not be shown, as you explained perfectly from your code analysis…

              MagicMirror_200930.JPG

              S 1 Reply Last reply Sep 30, 2020, 7:40 PM Reply Quote 0
              • S Offline
                SwissChemist @sdetweil
                last edited by Sep 30, 2020, 7:40 PM

                @sdetweil
                I would not mind to see 23:59 as end of a whole day event, but it would also be fine for me to see the day where it starts again…

                1 Reply Last reply Reply Quote 0
                • S Away
                  sdetweil @SwissChemist
                  last edited by Sep 30, 2020, 7:40 PM

                  @SwissChemist finding an acceptable “end” marker for “full day” event is challenging.

                  it certainly ends when the next day starts.

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  S 1 Reply Last reply Oct 1, 2020, 5:46 PM Reply Quote 0
                  • S Away
                    sdetweil @sdetweil
                    last edited by sdetweil Oct 1, 2020, 5:47 PM Oct 1, 2020, 5:46 PM

                    @SwissChemist can u look at this, your cal, in your timezone, 2.13 no modifications
                    showEnd:true,
                    maximumEntries:25,
                    2.13-german.png

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    1 Reply Last reply Reply Quote 0
                    • S Offline
                      SwissChemist
                      last edited by SwissChemist Oct 1, 2020, 8:07 PM Oct 1, 2020, 8:05 PM

                      @sdetweil
                      It’s getting better and better, great!

                      The only event, which is not correct yet, ist the 3-weekly 13-14. This should be in 21 days (Oct 22nd), exactly like the 3-weekly whole day. The following ones could be better controlled in an absolute time format…

                      S 1 Reply Last reply Oct 1, 2020, 8:10 PM Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 2 / 6
                      2 / 6
                      • First post
                        12/51
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy