MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-Calendar always shows 23:59 if showEndTime: True

    Scheduled Pinned Locked Moved Bug Hunt
    51 Posts 4 Posters 16.6k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      SwissChemist @sdetweil
      last edited by SwissChemist

      @sdetweil
      I am currently not sure how this will look like after changing from DST(UTC+2) to STD time(UTC+1).
      For sure this will happen on sunday, 25th of October. That’s why whole day events starting on 26th look differently.
      But how should it look like today? Oct 26th 01:00 - Oct 27th 00:59???

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @SwissChemist
        last edited by sdetweil

        @SwissChemist install 2.13
        and replace the ~/MagicMirror/modules/default/calendar/calendarfetcher.js
        with this
        https://www.dropbox.com/s/t7m1f49kvv3x2b1/calendarfetcher.js?dl=0

        save the old one

        it should correct dst/std time changes

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        S 1 Reply Last reply Reply Quote 0
        • S Offline
          SwissChemist @sdetweil
          last edited by

          @sdetweil
          3-weekly whole day now shows Okt 23, but it should be Okt 22

          As I have seen in the calendar file, switching from DST to STD time is correctly defined for last Sunday in October, that is 25th of October. So this should not influence an event on 22nd of October…

          Regarding events after switching from DST to STD time, I don’t have a clue, as I am not a dev, just a little experienced in testing…
          I tried to understand the calendar file. As far as I have seen, you have only the date for whole day events (without any time):

          BEGIN:VEVENT
          CREATED:20201001T205859Z
          DTEND;VALUE=DATE:20201023
          DTSTAMP:20201001T205900Z
          DTSTART;VALUE=DATE:20201022
          LAST-MODIFIED:20201001T205859Z
          RRULE:FREQ=WEEKLY;INTERVAL=3;BYDAY=TH
          SEQUENCE:1
          SUMMARY:3-weekly whole day
          UID:D718FE41-FF1B-43F6-9442-E9E43A41CCF0
          URL;VALUE=URI:
          END:VEVENT

          In this case DTSTART is 20201022 and DTEND is 20201023.

          For whole day events, can’t you simply set:
          ‘Begin’ to value of DTSTART 00:00 and
          ‘End’ to value of DTEND - 1day 23:59? (just as ical most probably uses 24:00 and that’s one day later)

          Maybe it’s not as simple as I assume, otherwise you would have tried that already…

          As we currently have TZOFFSET+0200 and switch to TZOFFSET+0100, I would rather expect that we see current events (planned after 25th Oct) on the monitor 1 hour too late.
          So that’s why I currently would rather expect:
          Oct 27th 01:00 - Oct 28th 00:59 for weekly whole day after switching to STD time instead of
          Oct 26th 23:00 - Oct 27th 22:59

          But as I mentioned before, maybe everything is much more complicated than I ever can imagine…
          MagicMirror_201003.JPG

          S 1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @SwissChemist
            last edited by sdetweil

            @SwissChemist your whole day event starts on one day, and ends on another

            DTEND;VALUE=DATE:20201023
            DTSTAMP:20201001T205900Z
            DTSTART;VALUE=DATE:20201022

            make up your mind…lol

            I changed all the whole day DTEND to the same date as the DTSTART

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            S 1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @sdetweil
              last edited by sdetweil

              @SwissChemist if it were easy!!!

              the rule processor has a bug w timezones
              and apparently with multiple whole day events, and with dst/std adjustment

              and the calendar parser is not ours, and the rule processor is not ours,

              and we are split into get dates to show and show dates… show dates(calendar.js) doesn’t know anything about the cal entry. it’s just gets a list of start and end times, in utc time

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • S Offline
                sdetweil
                last edited by

                I just uploaded another calendarfetcher.js to dropbox which corrects the timezone adjustment for daylight/std switch

                I was using the local system time instead of the calendar event start time to compare offsets with the rule created time

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil
                  last edited by

                  I like how it behaves now… we are both currently on DST, you switch the daylight 1st (Oct 25), and the events when system is on my timezone, change, and then we change later to daylight (Nov 1), and then we are back on the same adjustment again and the event times adjust again correctly…

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  1 Reply Last reply Reply Quote 0
                  • S Offline
                    SwissChemist
                    last edited by SwissChemist

                    @sdetweil
                    Wow, that looks great! Thanks very much for your endurance!

                    There is only that persistent ‘3-weekly whole day’ problem. It’s still one day too late. Most probably that’s so difficult, as it is a user defined interval, something strange seems to bring the parser to a wrong date…
                    For testing, I have added a 3-daily event. This shows correct start/end…

                    But the rest is great! Thanks very much!!!

                    MagicMirror_201005.JPG

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @SwissChemist
                      last edited by

                      @SwissChemist check the end date in your cal entry it was set for the next day.

                      2 -day event

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • S Offline
                        SwissChemist
                        last edited by

                        @sdetweil
                        All whole day events start at the right day and end one day later. There is no difference in the calendar file, whether it is a weekly, 2-weekly or 3-weekly event.
                        That’s why I do not understand, why weeklies and 2-weeklies are shown correctly and the 3-weekly is shown one day too late…

                        S 2 Replies Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 5
                        • 6
                        • 5 / 6
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy