MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Default Calendar Stopped Showing Recurring Events

    Scheduled Pinned Locked Moved Troubleshooting
    21 Posts 3 Posters 3.7k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AlvingerA Offline
      Alvinger @sdetweil
      last edited by

      @sdetweil I ran @BigSky 's calendar through my latest fix and it showed up correctly.

      S 1 Reply Last reply Reply Quote 0
      • B Offline
        BigSky @sdetweil
        last edited by

        @sdetweil glad the test file was helpful - and thanks again for looking into this!

        1 Reply Last reply Reply Quote 0
        • S Offline
          sdetweil @Alvinger
          last edited by

          @Alvinger i looked at your code… it fixes the results, but not the cause… I will look at resolving the cause the cause wastes storage and cycles

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          AlvingerA 1 Reply Last reply Reply Quote 0
          • AlvingerA Offline
            Alvinger @sdetweil
            last edited by

            @sdetweil It fixes the result while also retaining backward compatibility. From my viewpoint the cause is that calendarfetcher.js not only fetches but also filters. It should just fetch and let calendar.js do the filtering. But that would require substantial changes to both files. My “fix” is just a few lines of code.
            But I am all for fixing the cause!

            S 1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @Alvinger
              last edited by

              @Alvinger yeh, I agree on the ‘right’ fix, but don’t want to rewrite the whole thing…

              the ‘cause’ is that the rule.between(from date/time is set to yesterday (when NOT looking for pastEvents)
              so rrule dutifully returns events that could occur yesterday or before now today… .
              if not pastEvetns, from should be NOW…

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              AlvingerA 1 Reply Last reply Reply Quote 0
              • AlvingerA Offline
                Alvinger @sdetweil
                last edited by

                @sdetweil Aah, missed that one. But you still have to address the issue with calendarfetcher returning “only” maximumEntries even if broadcastPastEvents is set.

                S 1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil @Alvinger
                  last edited by

                  @Alvinger yes, i like your solution there

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  1 Reply Last reply Reply Quote 0
                  • 1
                  • 2
                  • 3
                  • 2 / 3
                  • First post
                    Last post
                  Enjoying MagicMirror? Please consider a donation!
                  MagicMirror created by Michael Teeuw.
                  Forum managed by Sam, technical setup by Karsten.
                  This forum is using NodeBB as its core | Contributors
                  Contact | Privacy Policy