MMM-BackgroundSlideshow does not respond to notifications

UncleRoger

I’m probably doing something wrong but it seems to me that MMM-BackgroundSlideshow is not responding to notifications.

I have MMM-Keypress installed which works fine with MMM-Pages but when I try to set it up to send notifications to MMM-BackgroundSlideshow, it’s like BS is ignoring them. (Using the same exact keys/configuration to send a notification to MMM-Pages works fine.)

Here are my config.js entries:

		{
			module: "MMM-Keypress",
			position: "bottom_right",
			config: {
				notifications: [
					{key: "Enter", notification: "PAGE_INCREMENT"},
//					{key: "Tab", notification: "PAGE_INCREMENT"},
//					{key: "Space", notification: "PAGE_INCREMENT"},
					{key: "MOUSE_SCROLL_UP", notification: "BACKGROUNDSLIDESHOW_PREVIOUS"},
					{key: "MOUSE_SCROLL_DOWN", notification: "BACKGROUNDSLIDESHOW_NEXT"},
				],
			}
		},

		{
			module: 'MMM-BackgroundSlideshow',
			position: 'fullscreen_below',
			config: {
				imagePaths: ['modules/MMM-BackgroundSlideshow/Paintings/'],
				transitionImages: true,
				randomizeImageOrder: true,
				slideshowSpeed: 3600000,
				resizeImages: true,
				maxWidth: 1080,
				maxHeight: 1920,
				backgroundSize: "contain",
				transitions: ["opacity"],
				showProgressBar: true,
			}
		},

Note that I’ve tried a whole host of keys/keycodes and they work fine with MMM-Pages but do nothing for MMM-BackgroundSlideshow.

I’m not sure what I’m doing wrong.

UncleRoger

Never mind… it appears to be a bug in the module as discussed here: https://github.com/darickc/MMM-BackgroundSlideshow/issues/127

UncleRoger

So the fix appears to be* to add the following line of code to the MMM-BackgroundSlideshow.js file at line ~175:

    //Quick and dirty fix to redirect the notification
    this.socketNotificationReceived(notification,payload);

Seems to be working now.

* https://github.com/darickc/MMM-BackgroundSlideshow/pull/135/commits/48ae1cb12408a119ec9dd07927ce953f9eaa2bf0#diff-58dd4b5e083de0ddd663e45190feabf1cabee2f0e3f6ca048c0f64a731888ff8R175-R176

(Just adding this in case someone comes here to search for an answer first before going to Github.)