Standard Weather Module showing unwanted header

karsten13

@rkorell said in Standard Weather Module showing unwanted header:

appendLocationToHeader

read the docs, there is no property with above name …

rkorell

@karsten13 OK, have found this as part of an if clause and as member of defaut configuration in module code.
If this causes the unwanted behaviour: sorry!

Thanks.
Ralf

rkorell

@karsten13 nope :-(
Deleting “appendLocationToHeader” doesn’t resolve the issue…
One of the headers (in this case weather_forecast instance) immediatly shows up if I disable the blackness of text/border-bottom …

Regards,
Ralf

rkorell

@karsten13 said in Standard Weather Module showing unwanted header:

there is no property with above name

the part of module code I’ve meant is obvioulsy doing something wrong:
getHeader is “explained” as “// Override getHeader method.”

	getHeader () {
		if (this.config.appendLocationNameToHeader && this.weatherProvider) {
			if (this.data.header) return `${this.data.header} ${this.weatherProvider.fetchedLocation()}`;
			else return this.weatherProvider.fetchedLocation();
		}

		return this.data.header ? this.data.header : "";
	},

I’ve simply replaced this with


getHeader () {
		return "";
	},

And - no surprise - header disappears.

Regards,
Ralf

rkorell

@rkorell OK, just seen at least one other mistake:
I’ve picked “appendLocationToHeader” but this should be “appendLocationNameToHeader” …

rkorell

@karsten13 ,
yupp this seems to do the trick.
undoing code changes and adding

appendLocationNameToHeader: false,

to weather config let the header disappear …
Thanks!

Ralf

(not understood why and how but at least this way the header lines are really not present - the blackness idea makes them invisible but they still occupy room.)

sdetweil

@rkorell the old weather api returned the location Name, and someone decided to show it in the MagicMirror module header field

but you can disable this function by setting the config property to false (default true)

the v3 api does NOT return the location Name, so you need to set the property to false AND YOU have to set the header manually
header:“…”, after the module:“weather”,

rkorell

@sdetweil said

by setting the config property to false (default true)

Dear Sam,
Thanks for this.
Which one of the config properties are you referencing to?
I‘ve set

header: „“

This definitely doesn‘t work because it‘s overwritten somewhere
.
Regards,
Ralf

sdetweil

@rkorell said in Standard Weather Module showing unwanted header:

Which one of the config properties are you referencing to?

appendLocationNameToHeader: false,

and for header

{
     module:"weather",
     header:"something",
     position:
     config: {
       ...
     }
}

all of these properies belong to MagicMirror, same for every module
https://docs.magicmirror.builders/modules/configuration.html#module-configuration

rkorell

@sdetweil said

appendLocationNameToHeader: false,

Yeah.
OK, already found this…

Regards,
Ralf