MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Module to Display JSON data from a FILE

    Scheduled Pinned Locked Moved Solved Requests
    21 Posts 3 Posters 3.1k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • M Offline
      mhr320 @sdetweil
      last edited by

      @sdetweil Oh, in “a forum” was relative to another forum, this is the first time, in a long time, i’ve used this forum. HERE has been great every time so far, sorry for the misunderstanding.

      M 1 Reply Last reply Reply Quote 1
      • S Offline
        sdetweil @sdetweil
        last edited by

        @mhr320 the author accepted my change request

        so you could go to the old folder (if you just renamed it) and git pull to get the update
        then swap(rename) the folders and retry with his code again
        and then delete mine

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        T 1 Reply Last reply Reply Quote 0
        • M Offline
          mhr320 @mhr320
          last edited by

          Whoa, that was fast on both of your parts. I went to his github page and saw several old open “issues” i figured he’d be asleep on the project, but wow! It worked, great job sir! I really look forward to my next issue.

          1 Reply Last reply Reply Quote 0
          • T Offline
            timdows @sdetweil
            last edited by

            @sdetweil

            Thanks for the PR

            Just approved the it, it did fail some prittier checks that I’ll fix later
            Hope you’ll find it usefull over here!

            https://github.com/timdows/MMM-JsonTable

            S 1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @timdows
              last edited by sdetweil

              @timdows you should add a git pre-commit hook to run prettier for whoever…

              here is mine
              .pre-commit

              #!/bin/sh
              FILES=$(git diff --cached --name-only --diff-filter=ACMR "*.js" "*.jsx *.json" | sed 's| |\\ |g')
              [ -z "$FILES" ] && exit 0
              
              # Prettify all selected files
              echo "$FILES" | xargs ./node_modules/.bin/prettier --write
              
              # Add back the modified/prettified files to staging
              echo "$FILES" | xargs git add
              
              exit 0
              

              and an npm postinstall script to copy to the git folder

              #!/bin/bash
              #echo copying git pre-commit hook 
              cp .pre-commit .git/hooks
              

              package.json

                "scripts": {
                  "postinstall":"whatever you call it"
              

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • 1
              • 2
              • 3
              • 3 / 3
              • First post
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy