Trading module

[plumcraft]

Yes, will be happy to try it !

thks

[alexyak]

Alright I’ve just published it. Enjoy: :)

https://forum.magicmirror.builders/topic/496/stocks

[plumcraft]

I got an error when trying your module :

stocks.js:110 GET http://finance.google.com/finance/info?client=ig&q=.DJI,MSFT,AAPL,GOOG,INTC,CICS,TSLA,FB getStocks @ stocks.js:110start @ stocks.js:19startModules @ loader.js:55(anonymous function) @ loader.js:40stylesheet.onload @ loader.js:190
192.168.0.31/:1 XMLHttpRequest cannot load http://finance.google.com/finance/info?client=ig&q=.DJI,MSFT,AAPL,GOOG,INTC,CICS,TSLA,FB. No ‘Access-Control-Allow-Origin’ header is present on the requested resource. Origin ‘http://192.168.0.31:8080’ is therefore not allowed access. The response had HTTP status code 500.

It might be a configuration issue on my side ?

Thanks

[alexyak]

@plumcraft Hmm… that’s strange why you’re getting the CORS error. It works for me directly from the chromium… Where’re you running it from?

[plumcraft]

@alexyak : I’m testing it from a remote computer and directly on my RPI , and same issue…, don’t get it :(

[alexyak]

ok then the easiest solution would be to move this call to the node_helper…

[alexyak]

@plumcraft Ok, I found a bug in the code. Try to pull the latest and see if it runs for you.

[plumcraft]

@alexyak : thanks for your quick reply but no luck with the latest pull

[plumcraft]

I’ve tried to enable Cors which looks like the issue here but does not make any difference

(I’ve followed instructions on this website : http://jonathanmh.com/how-to-enable-cors-in-express-js-node-js/)

[alexyak]

@plumcraft could you please try the following:

Update the electron.js (it’s in the \js\ folder). Instead of:

mainWindow = new BrowserWindow({width: 800, height: 600,  fullscreen: true, autoHideMenuBar: true, darkTheme: true, webPreferences: {nodeIntegration: false}});

Replace it with:

mainWindow = new BrowserWindow({width: 800, height: 600,  fullscreen: true, autoHideMenuBar: true, darkTheme: true, webPreferences: {nodeIntegration: false, webSecurity: false}});

[plumcraft]

@alexyak,

My bad Alexyak, it was working even if webSecurity was not set. It was an issue in my config.js, sorry for that.

Your module is working only on the RPI, not inside a browser (webSecurity: false or true) but it’s not a big deal.

I will try to find a solution

[alexyak]

@plumcraft the webSecurity flag will only work for running in the electron on RPI. Which web browser are you trying to run it in? It works for me for chrome and safari.

[plumcraft]

@alexyak I’m using Google Chrome, does not work on Safari either.

[alexyak]

@plumcraft could you please make sure that you pulled the latest version of the MM from github?

[plumcraft]

@alexyak Just tried it, i’m having the same issue :(

[MichMich]

To prevent these kind of issues (and improve security) I suggest all cross server calls are done in the node helper. (That’s what the node helper is for)

[alexyak]

@MichMich as a rule of thumb yes, but there could be exceptions :)

[alexyak]

@plumcraft I’ve updated the module to move the data request to the node_helper which means it should fix your CORS related error.
Just pull the latest.

[plumcraft]

@alexyak thanks, it works for me now :)

[alexyak]

@plumcraft great! Enjoy :)