@sdetweil I did a quick PR anyway, even if it’s not perfect, it’s better there’s a starting point for a fix than make someone repeat tracking it down to where I got to.
Read the statement by Michael Teeuw here.
Best posts made by DaveChild
-
RE: v2.22.0 | default calendar: no symbols with customEvents
Latest posts made by DaveChild
-
RE: v2.22.0 | default calendar: no symbols with customEvents
@sdetweil I did a quick PR anyway, even if it’s not perfect, it’s better there’s a starting point for a fix than make someone repeat tracking it down to where I got to.
-
RE: v2.22.0 | default calendar: no symbols with customEvents
@sdetweil I’ve not delved far into the code but it looks to me like the
symbolsForEvent
function in calendar.js is getting the default symbol with the default class, but then overwriting that default with the symbol from customerEvents - but not applying the default class to it.This might be fixed with applying
this.getCalendarPropertyAsArray
toev.symbol
in the linesymbols[0] = ev.symbol;
.I’d do a PR myself but I have nowhere near enough experience tinkering with MagicMirror to be pushing code to a default module :). But I think that’s where the problem is, and my solution will work around that issue crudely for the moment.
-
RE: v2.22.0 | default calendar: no symbols with customEvents
I’ve been having the same problem. In mine the
fas fa-fw fa-
prefix was missing, so I changed my config to this:customEvents: [ {keyword: "Games", symbol: "dice fas fa-fw fa-dice"}, {keyword: "Rugby", symbol: "running fas fa-fw fa-running"}, {keyword: "Guitar", symbol: "guitar fas fa-fw fa-guitar"} ],
I duplicated the “dice” at the start so it keeps working when the bug is fixed. And the icons appear now.
-
RE: How to autorestart MM once a day
@MaxPower said in How to autorestart MM once a day:
I recommend you then add the following crontab task:
* 4 * * * pm2 restart mm
Sorry to bump this old topic, but I found this searching for how to restart MM automatically and the crontab line given isn’t quite correct. That line will restart MM every minute from 4am to 5am. The line to get it to run just once is something like:
17 4 * * * pm2 restart mm
That’ll run at 4:17 am only.