• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Altering a Module

Scheduled Pinned Locked Moved Unsolved Troubleshooting
9 Posts 3 Posters 784 Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • R Offline
    rrslssr @sdetweil
    last edited by Jan 13, 2024, 7:33 PM

    @sdetweil I am sorry, but I do not understand your response.
    The original code lines @semox used in the module are:

    compliment.hide(0);
    ...
    compliment.show(self.config.animationSpeed, {lockString: this.name})
    ...
    compliment.hide(self.config.animationSpeed, {lockString: this.name})
    

    Are you saying that I should change the ()'s to {}'s in both instances?
    Or are you saying that the second Parm in the 2 longer .show/.hide commands shown above, should be in {}'s? If so, they already are are they not?

    Rich

    S 1 Reply Last reply Jan 13, 2024, 7:39 PM Reply Quote 0
    • S Offline
      sdetweil @rrslssr
      last edited by Jan 13, 2024, 7:39 PM

      @rrslssr the functions show() and hide() take 3 parms

      (speed, callback_function, options)

      https://docs.magicmirror.builders/development/core-module-file.html#module-instance-methods

      the ones you have only have 2 parms…

      I was suggesting, if you want to get rid of the errors, that you insert a function as the second parm

      and the simplest function, is the arrow function () => {}
      (parms in) => {function code}

      so, my thing is
      () (no parms) =>{} (empty function code)

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      R 2 Replies Last reply Jan 13, 2024, 7:47 PM Reply Quote 0
      • R Offline
        rrslssr @sdetweil
        last edited by Jan 13, 2024, 7:47 PM

        @sdetweil Thank you. Your explanation along with the link to the module-instance-methods, really help clarify things for this novice.

        Take care.
        Rich

        1 Reply Last reply Reply Quote 1
        • R Offline
          rrslssr @sdetweil
          last edited by Jan 13, 2024, 8:07 PM

          @sdetweil I’m happy to report that changing the code changes (as shown below) worked to eliminate the errors:

           compliment.show(self.config.animationSpeed, ()=>{}, {lockString: this.name})
          

          The only thing left is a warning : module tries to update the DOM without being displayed. But I don’t think I’ll worry about this error since my Frankenstein Module does not display anything.

          Thanks again for your help.
          Rich

          1 Reply Last reply Reply Quote 0
          • R Offline
            rmonkey
            last edited by Jan 14, 2024, 2:52 PM

            I want to do the exact same thing down the road when I need a new project to tinker with.

            Love it and thank you for posting the question and thank you to Sam for working through the solution.

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            1 / 1
            • First post
              9/9
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy