[FIXED] MMM-CalendarExt Facebook birtday events shown on two days

[modderhut]

so no one has seen this? does anyone use the facebook ical in their MMM-CalendarExt without a problem?

thx.

[ninjabreadman]

@modderhut What is the time zone for your MM? What is the time zone of your FB birthday feed/file? You can open an ics in any text editor. If they’re the same, it may not be getting properly interpreted.

[modderhut]

Thanks for your answer!

I guess MM is taking the timezone from the Pi and thats set to Amsterdam (GMT +1). The facebook link for the birthdays is not a actual file and can’t be opened with text editor but I am able to import the data into excel (need to change the url from “webcal” to “http” for that to work )

I have played with all settings related to timezone that I can think off but see no change, also commenting out the module’s locale setting does not change time, only formatting. same for the “fullDayEventLocalize”

One thing I noticed is that the Facebook events come in as 00:00 - 23:59 probably causing it to be displayed on two days. When I change the show: [‘daily’] to show: [‘monthly’] the time is still displayed as 00:00 - 23:59 but the events are only sown on the correct day.
If there was a problem with a localisation or time zone setting I would expect a deviation of full hours not 1 minute.

The Facebook data in excel does not show a locale setting any time or locale (see below) which makes me think the MMM-Calendar module translates “DURATION:P1D” into “00:00 - 23:59” somehow but are unable to spot that in the code.

BEGIN:VCALENDAR
PRODID:-//Facebook//NONSGML Facebook Events V1.0//EN
X-WR-CALNAME:Friends’ Birthdays
X-PUBLISHED-TTL:PT12H
X-ORIGINAL-URL:/events/birthdays/
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
BEGIN:VEVENT
DTSTART:20180217
SUMMARY:Bert birthday
RRULE:FREQ=YEARLY
DURATION:P1D
UID:@facebook.com
END:VEVENT
BEGIN:VEVENT
DTSTART:20180218
SUMMARY:Wouter birthday
RRULE:FREQ=YEARLY
DURATION:P1D
UID:@facebook.com
END:VEVENT

can anyone confirm they import facebook birtdays and they look ok for them?

[ninjabreadman]

@modderhut Strange that ['monthly'] displays correctly, but ['daily'] doesn’t. I don’t use the FB feed, so can’t confirm. For reference, this is handled in components/Calendar.js which passes the duration (e.g. P1D) to moment, which returns the start/end times. However, they should all fall on the same day (i.e. 00:00 and 23:59).

cc. @Sean

[A Former User]

Ok. I caught where the bugs from. I will fix it in a few hours. then I’ll reply about this again. you can update then.

[modderhut]

The code changes by Sean have fixed the problem, thanks for your quick follow up! The birthday events from Facebook now show up as whole day events on the correct dates.

[nn1mda]

I have the same issue, but with an ical calendar. All full day evens are shown on two days in both daily and weeks view. I have connected the same ical calendar to my Oulook and there it works fine.

Any suggestions?

[ninjabreadman]

@nn1mda What is the time zone of the calendar, and of your mirror?

[modderhut]

@nn1mda When you ruled out time config mistakes log an issue on the Github module page https://github.com/eouia/MMM-CalendarExt/issues . The developer is very fast with support but I think he only monitors those issues and not actively monitors this forum.

Please update this threat when you solve it s we all can benefit from the solution.

good luck!