Notification between modules

sdetweil

technically, you are not supposed to update the dom until getDom() method time.
you can update the data in the notificationReceived method, and then call updateDom() to indicate you have changes to present.

this will cause getDom() to be called.

grasshopper001

@sdetweil but I did call updateDom() in ModuleB…

grasshopper001

finally I solved this problem as @sdetweil told me: keep all coding of DOM within the getDom() function, initialize my data in start function, and update the data in the notificationReceived method.
the updateDom() function is repeatedly called after receiving “DOM_OBJECT_CREATED” notification.

idoodler

@grasshopper001 You are in two different scopes. Try to add .bind(this) to your setInterval’s callback.

Also do you see any errors on the browser side?

Open Chrome and navigate to your MagicMirror’s Webinterface
Open the Chrome Dev Tools via F12 (on Windows)
Keep an eye out for anything red in the console
Optional You can also directly debug your modules code in the dev tools.

strawberry 3.141

@idoodler he’s using arrow functions =>, therefore he stays in the same scope.

idoodler

@strawberry-3-141 Thanks, again what learned:)

sdetweil

@grasshopper001 nice work.

One comment to think about. You should not call updateDom() if you do NOT have changed content to present

This wastes cpu cycles, raising heat. And maybe preventing some other module from displaying properly.

grasshopper001

@sdetweil Thanks! I’ve rewritten my code according to your comment.

grasshopper001

@idoodler thanks for the help.The console part in the dev tool does help a lot!