• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

I possibly found an updateNotification bug that may be responsible for the out of memory errors

Scheduled Pinned Locked Moved Unsolved Troubleshooting
updatenotification
13 Posts 3 Posters 2.9k Views 5 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Offline
    sdetweil
    last edited by Mar 23, 2019, 11:20 PM

    I’ve spent the day looking over the module, and there are a number of bugs that had to be fixed.

    the design is synchronous calls to simple-gits module, but simple-gits uses promises under the covers, so everything is actually async, which exposes some potential data corruption

    also the module.js overwrites the this.status pointer on each notification from the helper, before checking if the data is useful (behind > 0)… which yanks the data out from under getDom().

    and getDom() processes for each good data message, overlaying anything prior… only one module status shows

    i am testing fixes for all of that…

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    1 Reply Last reply Reply Quote 1
    • E Offline
      ezarlive
      last edited by Mar 24, 2019, 6:22 AM

      Make a pull request ;)

      S 1 Reply Last reply Mar 24, 2019, 10:39 AM Reply Quote 0
      • S Offline
        sdetweil @ezarlive
        last edited by Mar 24, 2019, 10:39 AM

        @ezarlive testing… before sending the code

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • 1
        • 2
        • 2 / 2
        2 / 2
        • First post
          12/13
          Last post
        Enjoying MagicMirror? Please consider a donation!
        MagicMirror created by Michael Teeuw.
        Forum managed by Sam, technical setup by Karsten.
        This forum is using NodeBB as its core | Contributors
        Contact | Privacy Policy