• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

RMV module issue (no live data)

Scheduled Pinned Locked Moved Solved Troubleshooting
10 Posts 2 Posters 1.7k Views 2 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Away
    sdetweil @drfukc
    last edited by sdetweil Apr 18, 2019, 6:39 PM Apr 18, 2019, 6:38 PM

    @drfukc i looked at the source for the module u described, I see your pull request…

    		fDest: 'true',
    		fDestination1: 'Frankfurt (Main) Hauptbahnhof',
    		fDestination2: 'Frankfurt (Main) Flughafen Regionalbahnhof',
    		fDestination3: '',
    		fDestination4: '',
    		fDestination5: '',
    		lines: '', // "S1, U1,Tram 11"
    

    because they are in the defaults section of the code, all u have to do is set them in the config entry for this module in config.js
    that will override the defaults

    {
       module: "MMM-RMV",
       position: "center",
       config: {       
           		fDestination1: 'Frankfurt (Main) Hauptbahnhof',
           		fDestination2: 'Frankfurt (Main) Flughafen Regionalbahnhof',
           		fDestination3: 'something',
           		fDestination4: 'something else',
           		fDestination5: 'and even more',
        }
    }

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    1 Reply Last reply Reply Quote 0
    • S Away
      sdetweil
      last edited by sdetweil Apr 18, 2019, 6:41 PM Apr 18, 2019, 6:40 PM

      and the MMM-MRV.js code says (for example)

      else if (trains.direction === this.config.fDestination1 || trains.direction === this.config.fDestination2 || trains.direction === this.config.fDestination3 || trains.direction === this.config.fDestination4 || trains.direction === this.config.fDestination5) 
      				{	
      					if (trains.Product.catOutL == "S-Bahn" || trains.Product.catOutL == "Niederflurstraßenbahn")
      					{	countedLinesTram = countedLinesTram + 1;	}
      					else if (trains.Product.catOutL == "U-Bahn")
      					{	countedLinesSub = countedLinesSub + 1;	}
      					else if (trains.Product.catOutL == "Niederflurbus" || trains.Product.catOutL == "Bus")
      					{	countedLinesBus = countedLinesBus + 1;	}
      					else if (trains.Product.catOutL == "RB" || trains.Product.catOutL == "RE" || trains.Product.catOutL == "IC" || trains.Product.catOutL == "ICE" || trains.Product.catOutL == "R-Bahn" || trains.Product.catOutL == "EC")
      					{	countedLinesTrain = countedLinesTrain + 1;	}
      					else 
      					{	countedLines = countedLines + 1; }
      				}
      

      you should not have to edit the code

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      1 Reply Last reply Reply Quote 0
      • D Offline
        drfukc
        last edited by Apr 18, 2019, 8:03 PM

        @sdetweil
        I have not edited the code, I have created a pull-request.
        All I can see it that it is working in my environment with my proposed change but not with the default values.
        In case other users have a similar issue, I suggest to give it a try.

        S 1 Reply Last reply Apr 18, 2019, 8:11 PM Reply Quote 0
        • S Away
          sdetweil @drfukc
          last edited by Apr 18, 2019, 8:11 PM

          @drfukc said in RMV module issue (no live data):

          I have not edited the code, I have created a pull-request.

          well, you edited the source file, which is the same…

          it doesn’t matter what the defaults are (what u changed)…

          just set the values in config (as the deverloper expects you to do), and all is good…

          your ‘’ vs the original produce the same results… it doesn’t work…

          it was expected that you would put values in config, they override the defaults…

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          1 Reply Last reply Reply Quote 0
          • D Offline
            drfukc
            last edited by Apr 18, 2019, 8:30 PM

            @sdetweil
            if you are the author of the RMV module its perfect, if you are not the author of this module it is perfect as well.
            However, please accept that in my case the “MMM-RMV.js” requires auditing, otherwise it will not work.
            I would be more than pleased if all editing can be done in the “config.js”, at least in my case it does not work.
            The default values do not seem to be overriden.
            Any idea why?

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            1 / 1
            • First post
              10/10
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy