MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    .resume() is executed whenever even with wrong lockString?

    Scheduled Pinned Locked Moved Development
    10 Posts 3 Posters 1.1k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @Guest
      last edited by

      @Sean in module1, what is this.hidden?

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      ? 1 Reply Last reply Reply Quote 0
      • ? Offline
        A Former User @sdetweil
        last edited by

        @sdetweil said in .resume() is executed whenever even with wrong lockString?:

        @Sean in module1, what is this.hidden?

        https://github.com/MichMich/MagicMirror/blob/master/modules/README.md#available-module-instance-properties
        It’s one of default module attributes. (But in this case, useless.)

        S 1 Reply Last reply Reply Quote 0
        • S Offline
          sdetweil @Guest
          last edited by

          @Sean thanks. Forgot these attributes

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @Guest
            last edited by

            @Sean I reported the bug in your issue

            	show: function (speed, callback, options) {
            		if (typeof callback === "object") {
            			options = callback;
            			callback = function () { };
            		}
            
            		callback = callback || function () { };
            		options = options || {};
            
            		this.resume();   // < --- should not be done, MM.showModule will call back if allowed
            		MM.showModule(this, speed, callback, options);
            	}
            

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @Guest
              last edited by

              @Sean i see they have developed and accepted a fix for this. for next release

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • ? Offline
                A Former User
                last edited by

                Yes. I fix it with @eouia

                1 Reply Last reply Reply Quote 1
                • 1 / 1
                • First post
                  Last post
                Enjoying MagicMirror? Please consider a donation!
                MagicMirror created by Michael Teeuw.
                Forum managed by Sam, technical setup by Karsten.
                This forum is using NodeBB as its core | Contributors
                Contact | Privacy Policy