MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Need Help - Absolute Beginner - Code Posted!

    Scheduled Pinned Locked Moved Troubleshooting
    20 Posts 3 Posters 2.7k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • BKeyportB Offline
      BKeyport Module Developer
      last edited by

      vulnerabilities aren’t to be worried about if the project isn’t going to peek out to the internet.

      The "E" in "Javascript" stands for "Easy"

      1 Reply Last reply Reply Quote 0
      • B Offline
        bumrocks
        last edited by

        @BKeyport
        Which makes perfect sense but I am unclear what exactly might be peeking out if it connects to Internet for calendar stuff (intend to connect Google Calendar), updates for weather, Youtube module, and Amazon Alexa (if module is available)…I assume that all of these are in some way peeking and that most Magic Mirrors do in various ways. But, I am just a noob and can not say with any certainty. At the least, it is a daunting statement using the word “vulnerabilities”.

        Let me also add, it is quite confusing that the developer and his team recommend doing the manual install but leave out such specifics and how to handle them when they arise. I am not the first or last person to make this attempt with a Rasberry Pi 4 and with me following the directions given within the terminal I still end up with…

        fixed 15 of 20 vulnerabilities in 1052 scanned packages
          3 vulnerabilities required manual review and could not be updated
          2 package updates for 2 vulnerabilities involved breaking changes
          (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)
        
        

        Which absolutely leaves a noob such as I in a state of confusion as to what to do. Continuing on and leaving that by the wayside I get to the configuration of the config file and low and behold things that the instructions say I can alter or change are not available at all…zoom, electronOptions, & customCss are nonexistent from my config file. I see great care to help absolute beginners in various ways but some of the most basic instructions are either wrong or completely missing. I am thankful, do not get me wrong, for this site, this app, the developers, the input, etc. Figuring out stuff on my own will help me retain the knowledge and only better me in the future but I can’t help but feel bad for those that are less computer savvy as an absolute beginner. Sorry for my slight rant! Not sure why I started on it but my intention is not to be a negative dick. I have spent way more hours and $ on this project that I originally planned or anticipated as I assumed wrongfully that this would be easy. Nobody’s fault but my own.

        S BKeyportB 2 Replies Last reply Reply Quote 0
        • S Do not disturb
          sdetweil @bumrocks
          last edited by

          @bumrocks they CAN be altered, but are not there by default… yes, you have to discover them , if u have the need

          as for the issues and vulnerabilities, they are not in the MM code, but code it uses and that those use… where the MM owners have little to no control (or exposure to the problem)

          but many of the issues you present are why I built up the installer and updater scripts, to get you up and running, regardless of your platform choice

          this remains a volunteer project, where, if u are interested you can contribute. It is NOT a ‘product’

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          B 1 Reply Last reply Reply Quote 1
          • BKeyportB Offline
            BKeyport Module Developer @bumrocks
            last edited by

            @bumrocks In this case, if it’s not serving anything to the public, it’s generally fine. Grabbing things off the internet is usually fine… so, as long as you’re just grabbing things from the net, and it’s webports are not outside, you’re golden.

            The "E" in "Javascript" stands for "Easy"

            1 Reply Last reply Reply Quote 0
            • B Offline
              bumrocks @sdetweil
              last edited by

              @sdetweil Thank you for your response again. In my frustration I took a few days off and am now trying back at it…As far it not being a product and contributing, I understand very well and in what may be a feeble attempt did make remarks and suggestions for changes in a branch? off of the directions to include and/or remove certain information. On the Internet people can say or claim what they want whether truth or not but my intention is to not simply take what I can. I intend to contribute however I might, even if it is just monetarily. Unfortunately, I have not gotten very far and am still trying to figure out why.

              In trying to simplify my life, I did as you suggested, changed the MagicMirror directory name and then tried an install from your script. After running the primary command

              curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/raspberry.sh
              

              I end up with a bunch of return code that ends with this (let me know if you need the full code it gives back)…

              t -dpms
              			else
              			  echo "lxsession screen saver already disabled" >> $logfile
              			fi
              		fi
              	fi
              fi
              echo " "
              if [ $pm2setup -eq $true ]; then
              	rmessage="pm2 start MagicMirror"
              else
                rmessage="DISPLAY=:0 npm start"
              fi
              echo -e "\e[92mWe're ready! Run \e[1m\e[97m$rmessage\e[0m\e[92m from the ~/MagicMirror directory to start your MagicMirror.\e[0m" | tee -a $logfile
              
              echo " "
              echo " "
              
              date +"install completed - %a %b %e %H:%M:%S %Z %Y" >>$logfile
              pi@MagicMirror2:~ $ 
              
              

              It takes a matter of seconds to return all this and therefore is evident that nothing actually was installed. To confirm I have no new MagicMirror folder in my system, at least that I can find. Not within the /home/pi folder nor further back within the root directory. So I am at a loss as to what I now need to do. I tried running some other command but it also told me that Magic Mirror was not installed…

              echo
              			 echo or git stash pop to restore them all
              			 echo
              			 echo WARNING..
              			 echo WARNING.. either will overlay the file just installed by the update
              			 echo WARNING..
              			 if [ $set_username == $true ]; then
              			    git config --global --unset user.name >>/$logfile
              					git config --global --unset user.email >>/$logfile
              			 fi 
              		 fi
              	fi
              	# return to original folder
              	cd - >/dev/null
              	date +"Upgrade ended - %a %b %e %H:%M:%S %Z %Y" >>$logfile
              else
              	echo It appears MagicMirror has not been installed on this system
              	echo please run the installer, "raspberry.sh" first
              fi
              
              

              Thank you for your time and assistance in the matter. I have no issue starting from scratch if needed. Please advise :exploding_head:

              @BKeyport Understood…Makes sense and thank you! I feel a bit better now!

              1 Reply Last reply Reply Quote 0
              • B Offline
                bumrocks
                last edited by

                Here is the full code as it is returned to me…

                pi@MagicMirror2:~ $ curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/raspberry.sh
                #!/bin/bash
                # This is an installer script for MagicMirror2. It works well enough
                # that it can detect if you have Node installed, run a binary script
                # and then download and run MagicMirror2.
                
                if [ $USER == 'root' ]; then
                	 echo Please login as a user to execute the MagicMirror installation,  not root
                	 exit 1
                fi
                
                echo -e "\e[0m"
                echo '$$\      $$\                     $$\           $$\      $$\ $$\                                          $$$$$$\'
                echo '$$$\    $$$ |                    \__|          $$$\    $$$ |\__|                                        $$  __$$\'
                echo '$$$$\  $$$$ | $$$$$$\   $$$$$$\  $$\  $$$$$$$\ $$$$\  $$$$ |$$\  $$$$$$\   $$$$$$\   $$$$$$\   $$$$$$\  \__/  $$ |'
                echo '$$\$$\$$ $$ | \____$$\ $$  __$$\ $$ |$$  _____|$$\$$\$$ $$ |$$ |$$  __$$\ $$  __$$\ $$  __$$\ $$  __$$\  $$$$$$  |'
                echo '$$ \$$$  $$ | $$$$$$$ |$$ /  $$ |$$ |$$ /      $$ \$$$  $$ |$$ |$$ |  \__|$$ |  \__|$$ /  $$ |$$ |  \__|$$  ____/'
                echo '$$ |\$  /$$ |$$  __$$ |$$ |  $$ |$$ |$$ |      $$ |\$  /$$ |$$ |$$ |      $$ |      $$ |  $$ |$$ |      $$ |'
                echo '$$ | \_/ $$ |\$$$$$$$ |\$$$$$$$ |$$ |\$$$$$$$\ $$ | \_/ $$ |$$ |$$ |      $$ |      \$$$$$$  |$$ |      $$$$$$$$\'
                echo '\__|     \__| \_______| \____$$ |\__| \_______|\__|     \__|\__|\__|      \__|       \______/ \__|      \________|'
                echo '                       $$\   $$ |'
                echo '                       \$$$$$$  |'
                echo '                        \______/'
                echo -e "\e[0m"
                
                doInstall=1
                true=1
                false=0
                # Define the tested version of Node.js.
                NODE_TESTED="v10.1.0"
                NPM_TESTED="V6.0.0"
                USER=`whoami`
                PM2_FILE=pm2_MagicMirror.json
                forced_arch=
                pm2setup=$false
                
                trim() {
                    local var="$*"
                    # remove leading whitespace characters
                    var="${var#"${var%%[![:space:]]*}"}"
                    # remove trailing whitespace characters
                    var="${var%"${var##*[![:space:]]}"}"
                    echo -n "$var"
                }
                
                cd $HOME
                
                mac=$(uname -s)
                if [ 0 -eq 1 ]; then
                	if [ "$0" == "bash" ]; then
                		logdir=.
                	else
                		if [ $mac == 'Darwin' ]; then
                			echo this is a mac >> $logfile
                			logdir=$(dirname "$0")
                		else
                			# put the log where the script is located
                				logdir=$(dirname $(readlink -f "$0"))
                		fi
                	fi
                
                	# if the script was execute from the web
                	if [[ $logdir != *"MagicMirror/installers"* ]]; then
                		# use the MagicMirror/installers folder, if setup
                		if [ -d MagicMirror ]; then
                			cd ~/MagicMirror/installers >/dev/null
                				logdir=$(pwd)
                			cd - >/dev/null
                		else
                			# use the users home folder if initial install
                			logdir=$HOME
                		fi
                	fi
                fi
                logfile=$HOME/install.log
                echo install log being saved to $logfile
                
                # Determine which Pi is running.
                date +"install starting  - %a %b %e %H:%M:%S %Z %Y" >>$logfile
                ARM=$(uname -m)
                echo installing on $ARM processor system >>$logfile
                echo the os is $(lsb_release -a 2>/dev/null) >> $logfile
                OS=$(lsb_release -a 2>/dev/null | grep name: | awk '{print $2}')
                # Check the Raspberry Pi version.
                if [ "$ARM" != "armv7l" ]; then
                  read -p "this appears not to be a Raspberry Pi 2 or 3, do you want to continue installation (y/N)?" choice
                	choice="${choice:-N}"
                	if [[ $choice =~ ^[Nn]$ ]]; then
                	  echo user stopped install on $ARM hardware  >>$logfile
                		echo -e "\e[91mSorry, your Raspberry Pi is not supported."
                		echo -e "\e[91mPlease run MagicMirror on a Raspberry Pi 2 or 3."
                		echo -e "\e[91mIf this is a Pi Zero, the setup will configure to run in server only mode wih a local browser."
                		exit;
                	fi
                fi
                
                # Define helper methods.
                function command_exists () { type "$1" &> /dev/null ;}
                function verlte() {  [ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ];}
                function verlt() { [ "$1" = "$2" ] && return 1 || verlte $1 $2 ;}
                
                # Update before first apt-get
                if [ $mac != 'Darwin' ]; then
                	echo -e "\e[96mUpdating packages ...\e[90m" | tee -a $logfile
                	upgrade=$false
                	update=$(sudo apt-get update 2>&1)
                    # sudo apt-get update --allow-releaseinfo-change
                	echo $update >> $logfile
                	update_rc=$?
                    if [ $(echo $update | grep -i "is not valid yet" | wc -l) -ne 0 ]; then
                       echo -e "\e[91mSystem date/time is in the past, please correct ...\e[90m" | tee -a $logfile
                       exit 1
                    fi
                	if [ $update_rc -ne 0 ]; then
                
                        echo -e "\e[91mUpdate failed, retrying installation ...\e[90m" | tee -a $logfile
                        if [ $(echo $update | grep "apt-secure" | wc -l) -eq 1 ]; then
                	        update=$(sudo apt-get update --allow-releaseinfo-change 2>&1)
                	        update_rc=$?
                	        echo $update >> $logfile
                	        if [ $update_rc -ne 0 ]; then
                		        echo "second apt-get update failed" $update | tee -a $logfile
                		        exit 1
                	        else
                		        echo "second apt-get update completed ok" >> $logfile
                		        upgrade=$true
                	        fi
                        fi
                	else
                		echo "apt-get update  completed ok" >> $logfile
                		upgrade=$true
                	fi
                	if [ $upgrade -eq $true ]; then
                	   echo "apt-get upgrade  started" >> $logfile
                	   upgrade_result=$(sudo apt-get --assume-yes upgrade  2>&1)
                		 upgrade_rc=$?
                		 echo apt upgrade result ="rc=$upgrade_rc $upgrade_result" >> $logfile
                	fi
                
                	# Installing helper tools
                	echo -e "\e[96mInstalling helper tools ...\e[90m" | tee -a $logfile
                	sudo apt-get --assume-yes install curl wget git build-essential unzip  >>$logfile
                fi
                
                # Check if we need to install or upgrade Node.js.
                echo -e "\e[96mCheck current Node installation ...\e[0m" | tee -a $logfile
                NODE_INSTALL=false
                if command_exists node; then
                	echo -e "\e[0mNode currently installed. Checking version number." | tee -a $logfile
                	NODE_CURRENT=$(node -v)
                	if [ "$NODE_CURRENT." == "." ]; then
                	   NODE_CURRENT="V1.0.0"
                		 echo forcing low Node version  >> $logfile
                	fi
                	echo -e "\e[0mMinimum Node version: \e[1m$NODE_TESTED\e[0m" | tee -a $logfile
                	echo -e "\e[0mInstalled Node version: \e[1m$NODE_CURRENT\e[0m" | tee -a $logfile
                	if verlte $NODE_CURRENT $NODE_TESTED; then
                		echo -e "\e[96mNode should be upgraded.\e[0m" | tee -a $logfile
                		NODE_INSTALL=true
                
                		# Check if a node process is currenlty running.
                		# If so abort installation.
                		if pgrep "node" > /dev/null; then
                			echo -e "\e[91mA Node process is currently running. Can't upgrade." | tee -a $logfile
                			echo "Please quit all Node processes and restart the installer." | tee -a $logfile
                			echo $(ps -ef | grep node | grep -v \-\-color) | tee -a $logfile
                			exit;
                		fi
                
                	else
                		echo -e "\e[92mNo Node.js upgrade necessary.\e[0m" | tee -a $logfile
                	fi
                
                else
                	echo -e "\e[93mNode.js is not installed.\e[0m" | tee -a $logfile
                	NODE_INSTALL=true
                fi
                # Install or upgrade node if necessary.
                if $NODE_INSTALL; then
                
                	echo -e "\e[96mInstalling Node.js ...\e[90m" | tee -a $logfile
                
                	# Fetch the latest version of Node.js from the selected branch
                	# The NODE_STABLE_BRANCH variable will need to be manually adjusted when a new branch is released. (e.g. 7.x)
                	# Only tested (stable) versions are recommended as newer versions could break MagicMirror.
                	if [ $mac == 'Darwin' ]; then
                	  brew install node
                	else
                		NODE_STABLE_BRANCH="10.x"
                		# sudo apt-get install --only-upgrade libstdc++6
                		node_info=$(curl -sL https://deb.nodesource.com/setup_$NODE_STABLE_BRANCH | sudo -E bash - )
                		echo Node release info = $node_info >> $logfile
                		if [ "$(echo $node_info | grep "not currently supported")." == "." ]; then
                			sudo apt-get install -y nodejs
                		else
                			echo node $NODE_STABLE_BRANCH version installer not available, doing manually >>$logfile
                			# no longer supported install
                			sudo apt-get install -y --only-upgrade libstdc++6 >> $logfile
                			# have to do it manually
                			node_vnum=$(echo $NODE_STABLE_BRANCH | awk -F. '{print $1}')
                			# get the highest release number in the stable branch line for this processor architecture
                			node_ver=$(curl -sL https://unofficial-builds.nodejs.org/download/release/index.tab | grep $ARM | grep -m 1 v$node_vnum | awk '{print $1}')
                			echo "latest release in the $NODE_STABLE_BRANCH family for $ARM is $node_ver" >> $logfile
                			curl -sL https://unofficial-builds.nodejs.org/download/release/$node_ver/node-$node_ver-linux-$ARM.tar.gz >node_release-$node_ver.tar.gz
                			cd /usr/local
                			echo using release tar file = node_release-$node_ver.tar.gz >> $logfile
                			sudo tar --strip-components 1 -xzf  $HOME/node_release-$node_ver.tar.gz
                			cd - >/dev/null
                			rm ./node_release-$node_ver.tar.gz
                		fi
                		# get the new node version number
                		new_ver=$(node -v 2>&1)
                		# if there is a failure to get it due to a missing library
                		if [ $(echo $new_ver | grep "not found" | wc -l) -ne 0 ]; then
                		  #
                			sudo apt-get install -y --only-upgrade libstdc++6 >> $logfile
                		fi
                		echo node version is $(node -v 2>&1 >>$logfile)
                	fi
                	echo -e "\e[92mNode.js installation Done! version=$(node -v)\e[0m" | tee -a $logfile
                fi
                # Check if we need to install or upgrade npm.
                echo -e "\e[96mCheck current NPM installation ...\e[0m" | tee -a $logfile
                NPM_INSTALL=false
                if command_exists npm; then
                	echo -e "\e[0mNPM currently installed. Checking version number." | tee -a $logfile
                	NPM_CURRENT='V'$(npm -v)
                	echo -e "\e[0mMinimum npm version: \e[1m$NPM_TESTED\e[0m" | tee -a $logfile
                	echo -e "\e[0mInstalled npm version: \e[1m$NPM_CURRENT\e[0m" | tee -a $logfile
                	if verlte $NPM_CURRENT $NPM_TESTED; then
                		echo -e "\e[96mnpm should be upgraded.\e[0m" | tee -a $logfile
                		NPM_INSTALL=true
                
                		# Check if a node process is currently running.
                		# If so abort installation.
                		if pgrep "npm" > /dev/null; then
                			echo -e "\e[91mA npm process is currently running. Can't upgrade." | tee -a $logfile
                			echo "Please quit all npm processes and restart the installer." | tee -a $logfile
                			exit;
                		fi
                	else
                		echo -e "\e[92mNo npm upgrade necessary.\e[0m" | tee -a $logfile
                	fi
                else
                	echo -e "\e[93mnpm is not installed.\e[0m" | tee -a $logfile
                	NPM_INSTALL=true
                fi
                
                # Install or upgrade node if necessary.
                if $NPM_INSTALL; then
                
                	echo -e "\e[96mInstalling npm ...\e[90m" | tee -a $logfile
                
                	# Fetch the latest version of npm from the selected branch
                	# The NODE_STABLE_BRANCH variable will need to be manually adjusted when a new branch is released. (e.g. 7.x)
                	# Only tested (stable) versions are recommended as newer versions could break MagicMirror.
                
                	#NODE_STABLE_BRANCH="9.x"
                	#curl -sL https://deb.nodesource.com/setup_$NODE_STABLE_BRANCH | sudo -E bash -
                  #
                	# if this is a mac, npm was installed with node
                	if [ $mac != 'Darwin' ]; then
                		sudo apt-get install -y npm >>$logfile
                	fi
                	# update to the latest.
                	echo upgrading npm to latest >> $logfile
                	sudo npm i -g npm  >>$logfile
                	echo -e "\e[92mnpm installation Done! version=V$(npm -v)\e[0m" | tee -a $logfile
                fi
                
                # Install MagicMirror
                cd ~
                if [ $doInstall == 1 ]; then
                	if [ -d "$HOME/MagicMirror" ] ; then
                		echo -e "\e[93mIt seems like MagicMirror is already installed." | tee -a $logfile
                		echo -e "To prevent overwriting, the installer will be aborted." | tee -a $logfile
                		echo -e "Please rename the \e[1m~/MagicMirror\e[0m\e[93m folder and try again.\e[0m" | tee -a $logfile
                		echo ""
                		echo -e "If you want to upgrade your installation run \e[1m\e[97mupgrade-script\e[0m from the ~/MagicMirror/installers directory." | tee -a $logfile
                		echo ""
                		exit;
                	fi
                
                	echo -e "\e[96mCloning MagicMirror ...\e[90m" | tee -a $logfile
                	if git clone --depth=1 https://github.com/MichMich/MagicMirror.git; then
                		echo -e "\e[92mCloning MagicMirror Done!\e[90m" | tee -a $logfile
                		# replace faulty run-start.sh
                		curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/run-start.sh >MagicMirror/run-start.sh
                		chmod +x MagicMirror/run-start.sh
                	else
                		echo -e "\e[91mUnable to clone MagicMirror. \e[90m" | tee -a $logfile
                		exit;
                	fi
                
                	cd ~/MagicMirror  || exit
                	if [ $(grep version package.json | awk -F: '{print $2}') == '"2.9.0",' -a $ARM == 'armv6l' ]; then
                	    git fetch https://github.com/MichMich/MagicMirror.git develop >/dev/null 2>&1
                		git branch develop FETCH_HEAD > /dev/null 2>&1
                		git checkout develop > /dev/null 2>&1
                	fi
                	# if this is v 2.11 or higher
                	newver=$(grep -i version package.json | awk -F\" '{ print $4 }')
                	if verlte "2.11.0" $newver; then
                	  # if one of the older devices, fix the start script to execute in serveronly mode
                	  if [ "$ARM" == "armv6l" ]; then
                		  # fixup the start script
                		  sed '/start/ c \    "start\"\:\"./run-start.sh $1\",' < package.json 	>new_package.json
                		  if [ -s new_package.json ]; then
                		  	cp new_package.json package.json
                		  	rm new_package.json
                		  	echo "package.json update for armv6l completed ok" >>$logfile
                		  else
                		  	echo "package.json update for armv6l failed " >>$logfile
                		  fi
                		  curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/run-start.sh >run-start.sh
                		  chmod +x run-start.sh
                	  elif [ "$ARM" == "x86_64" -a "$OS" == 'buster' ]; then
                	  	cd fonts
                	  	   sed '/roboto-fontface/ c \    "roboto-fontface": "latest"' < package.json 	>new_package.json
                	  	   if [ -s new_package.json ]; then
                		  	cp new_package.json package.json
                		  	rm new_package.json
                		  	echo "package.json update for x86 fontface completed ok" >>$logfile
                		  fi
                	  	cd -
                	  elif [ $mac == 'Darwin' ]; then
                	  	   rm vendor/package-lock.json
                	  	   echo "erase vendor package-lock.json to allow later nan/fsevents install on mac" >>$logfile
                	  fi
                	fi
                    if [ ! -e css/custom.css ]; then
                       touch css/custom.css
                    fi
                	echo -e "\e[96mInstalling dependencies ...\e[90m" | tee -a $logfile
                	rm package-lock.json 2>/dev/null
                	npm_i_r=$(npm install $forced_arch --only=prod)
                    npm_i_rc=$?
                    if [ $newver == '2.11.0' ]; then
                      # fixup missing eslint (in dev dependencies)
                  	  npm install eslint >>$logfile
                	fi
                    if [ $npm_i_rc -eq 0 ]; then
                		echo -e "\e[92mDependencies installation Done!\e[90m" | tee -a $logfile
                	else
                        if [ $(echo $npm_i_r | grep "CERT_NOT_YET_VALID" | wc -l) -ne 0 ]; then
                            echo "\e[91mSystem date/time is in the past, please correct \e[90m" | tee -a $logfile
                        fi
                		echo -e "\e[91mUnable to install dependencies! \e[90m" | tee -a $logfile
                		exit;
                	fi
                	# fixup permissions on sandbox file if it exists
                	if [ -f node_modules/electron/dist/chrome-sandbox ]; then
                		 echo "fixing sandbox permissions" >>$logfile
                		 sudo chown root node_modules/electron/dist/chrome-sandbox 2>/dev/null
                		 sudo chmod 4755 node_modules/electron/dist/chrome-sandbox 2>/dev/null
                	fi
                	# if this an armv6l device (pi 0/1)
                	# if [ $ARM == 'armv6l' ]; then
                	#	# if this is the updated release
                	#	if ! verlt $(grep -i version package.json | awk -F\" '{ print $4 }')  2.10; then
                	#		# replace the start command with the old one
                	#		grep -v start package.json  | sed '/"scripts": {/a \ \ \ \ "start":\ "bash run-start.sh",' >package.json
                	#	fi
                	# fi
                	# Use sample config for start MagicMirror
                	echo setting up initial config.js | tee -a $logfile
                	cp config/config.js.sample config/config.js
                fi
                # Check if plymouth is installed (default with PIXEL desktop environment), then install custom splashscreen.
                echo -e "\e[96mCheck plymouth installation ...\e[0m" | tee -a $logfile
                if command_exists plymouth; then
                	THEME_DIR="/usr/share/plymouth/themes"
                	echo -e "\e[90mSplashscreen: Checking themes directory.\e[0m" | tee -a $logfile
                	if [ -d $THEME_DIR ]; then
                		echo -e "\e[90mSplashscreen: Create theme directory if not exists.\e[0m" | tee -a $logfile
                		if [ ! -d $THEME_DIR/MagicMirror ]; then
                			sudo mkdir $THEME_DIR/MagicMirror
                		fi
                
                		if sudo cp ~/MagicMirror/splashscreen/splash.png $THEME_DIR/MagicMirror/splash.png && sudo cp ~/MagicMirror/splashscreen/MagicMirror.plymouth $THEME_DIR/MagicMirror/MagicMirror.plymouth && sudo cp ~/MagicMirror/splashscreen/MagicMirror.script $THEME_DIR/MagicMirror/MagicMirror.script; then
                			echo
                			if [ "$(which plymouth-set-default-theme)." != "." ]; then
                				if sudo plymouth-set-default-theme -R MagicMirror; then
                					echo -e "\e[92mSplashscreen: Changed theme to MagicMirror successfully.\e[0m" | tee -a $logfile
                				else
                					echo -e "\e[91mSplashscreen: Couldn't change theme to MagicMirror!\e[0m" | tee -a $logfile
                				fi
                			fi
                		else
                			echo -e "\e[91mSplashscreen: Copying theme failed!\e[0m" | tee -a $logfile
                		fi
                	else
                		echo -e "\e[91mSplashscreen: Themes folder doesn't exist!\e[0m" | tee -a $logfile
                	fi
                else
                	echo -e "\e[93mplymouth is not installed.\e[0m" | tee -a $logfile
                fi
                
                # Use pm2 control like a service MagicMirror
                read -p "Do you want use pm2 for auto starting of your MagicMirror (y/N)?" choice
                choice="${choice:-N}"
                if [[ $choice =~ ^[Yy]$ ]]; then
                      echo install and setup pm2 | tee -a $logfile
                 			# assume pm2 will be found on the path
                			pm2cmd=pm2
                			# check to see if already installed
                			pm2_installed=$(which $pm2cmd)
                			up=""
                			if [ $mac == 'Darwin' ]; then
                				 up="--unsafe-perm"
                				 launchctl=launchctl
                				 launchctl_path=$(which $launchctl)
                				 `export PATH=$PATH:${launchctl_path%/$launchctl}`
                			fi
                			# check to see if already installed
                			pm2_installed=$(which $pm2cmd)
                			if [  "$pm2_installed." != "." ]; then
                			    # does it work?
                					pm2_fails=$(pm2 list | grep -i -m 1 "uptime" | wc -l )
                					if [ $pm2_fails != 1 ]; then
                					   # uninstall it
                						 echo pm2 installed, but does not work, uninstalling >> $logfile
                					   sudo npm uninstall $up -g pm2 >> $logfile
                						 # force reinstall
                				     pm2_installed=
                					fi
                			fi
                			# if not installed
                			if [  "$pm2_installed." == "." ]; then
                				# install it.
                				echo pm2 not installed, installing >>$logfile
                				result=$(sudo npm install $up -g pm2 2>&1)
                				echo pm2 install result $result >>$logfile
                				# if this is a mac
                				if [ $mac == 'Darwin' ]; then
                					echo "this is a mac, fixup for path" >>$logfile
                					# get the location of pm2 install
                					# parse the npm install output to get the command
                					pm2cmd=`echo $result | awk -F -  '{print $1}' | tr -d '[:space:]'`
                					c='/pm2'
                					# get the path only
                					echo ${pm2cmd%$c} >installers/pm2path
                				fi
                			fi
                			echo "get the pm2 platform specific startup command" >>$logfile
                			# get the platform specific pm2 startup command
                			v=$($pm2cmd startup | tail -n 1)
                			if [ $mac != 'Darwin' ]; then
                				# check to see if we can get the OS package name (Ubuntu)
                				if [ $(which lsb_release| wc -l) >0 ]; then
                					# fix command
                					# if ubuntu 18.04, pm2 startup gets something wrong
                					if [ $(lsb_release  -r | grep -m1 18.04 | wc -l) > 0 ]; then
                						 v=$(echo $v | sed 's/\/bin/\/bin:\/bin/')
                					fi
                				fi
                			fi
                			echo "startup command = $v" >>$logfile
                			# execute the command returned
                            $v 2>&1 >>$logfile
                			echo "pm2 startup command done" >>$logfile
                			# is this is mac
                			# need to fix pm2 startup, only on catalina
                			if [ $mac == 'Darwin' ]; then
                                if [ $(sw_vers -productVersion | head -c 6) == '10.15.' ]; then
                					# only do if the faulty tag is present (pm2 may fix this, before the script is fixed)
                					if [ $(grep -m 1 UserName /Users/$USER/Library/LaunchAgents/pm2.$USER.plist | wc -l) -eq 1 ]; then
                						# copy the pm2 startup file config
                						cp  /Users/$USER/Library/LaunchAgents/pm2.$USER.plist .
                						# edit out the UserName key/value strings
                						sed -e '/UserName/{N;d;}' pm2.$USER.plist > pm2.$USER.plist.new
                						# copy the file back
                						sudo cp pm2.$USER.plist.new /Users/$USER/Library/LaunchAgents/pm2.$USER.plist
                					fi
                				fi
                			fi
                		# if the user is no pi, we have to fixup the pm2 json file
                		echo "configure the pm2 config file for MagicMirror" >>$logfile
                		# if the files we need aren't here, get them
                		if [ ! -e installers/pm2_MagicMirror.json ]; then
                			curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/pm2_MagicMirror.json >installers/pm2_MagicMirror.json
                			curl -sl https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/mm.sh >installers/mm.sh
                			chmod +x installers/mm.sh
                		fi
                		if [ "$USER"  != "pi" ]; then
                			echo the user is not pi >>$logfile
                			# go to the installers folder
                			cd installers
                			# edit the startup script for the right user
                			echo change mm.sh >>$logfile
                			 if [ ! -e mm_temp.sh ]; then
                			   echo save copy of mm.sh >> $logfile
                			   cp mm.sh mm_temp.sh
                			 fi
                			 if [ $(grep pi mm_temp.sh | wc -l) -gt 0 ]; then
                			  echo change hard coded pi username  >> $logfile
                				sed 's/pi/'$USER'/g' mm_temp.sh >mm.sh
                			 else
                			  echo change relative home path to hard coded path >> $logfile
                			  hf=$(echo $HOME |sed 's/\//\\\//g')
                			  sed 's/\~/'$hf'/g' mm_temp.sh >mm.sh
                			 fi
                			# edit the pms config file for the right user
                			echo change $PM2_FILE >>$logfile
                			sed 's/pi/'$USER'/g' $PM2_FILE > pm2_MagicMirror_new.json
                			# make sure to use the updated file
                			PM2_FILE=pm2_MagicMirror_new.json
                			# if this is a mac
                			if [ $mac == 'Darwin' ]; then
                				 # copy the path file to the system paths list
                				 sudo cp ./pm2path /etc/paths.d
                				 # change the name of the home path for mac
                				 sed 's/home/Users/g' $PM2_FILE > pm2_MagicMirror_new1.json
                				 # make sure to use the updated file
                				 PM2_FILE=pm2_MagicMirror_new1.json
                			fi
                			echo now using this config file $PM2_FILE >>$logfile
                			# go back one cd level
                			cd - >/dev/null
                		fi
                		echo start MagicMirror via pm2 now >>$logfile
                		# tell pm2 to start the app defined in the config file
                		$pm2cmd start $HOME/MagicMirror/installers/$PM2_FILE
                		# tell pm2 to save that configuration, for start at boot
                		echo save MagicMirror pm2 config now  >>$logfile
                		$pm2cmd save
                		echo stop MagicMirror via pm2 now >>$logfile
                		#$pm2cmd stop MagicMirror
                		pm2setup=$true
                fi
                # Disable Screensaver
                
                read -p "Do you want to disable the screen saver? (y/N)?" choice
                choice="${choice:-Y}"
                if [[ $choice =~ ^[Yy]$ ]]; then
                  # if this is a mac
                	if [ $mac == 'Darwin' ]; then
                	  # get the current setting
                	  setting=$(defaults -currentHost read com.apple.screensaver idleTime)
                		# if its on
                		if [ "$setting" != 0 ] ; then
                		  # turn it off
                			echo disable screensaver via mac profile >> $logfile
                			defaults -currentHost write com.apple.screensaver idleTime 0
                		else
                			echo mac profile screen saver already disabled >> $logfile
                		fi
                	else
                	  # find out if some screen saver running
                
                		# get just the running processes and args
                		# just want the program name (1st token)
                		# find the 1st with 'saver' in it (should only be one)
                		# parse with path char, get the last field ( the actual pgm name)
                
                	  screen_saver_running=$(ps -A -o args | awk '{print $1}' | grep -m1 [s]aver | awk -F\/ '{print $NF}');
                
                		# if we found something
                		if [ "$screen_saver_running." != "." ]; then
                		  # some screensaver running
                			case "$screen_saver_running" in
                			 mate-screensaver) echo 'mate screen saver' >>$logfile
                						gsettings set org.mate.screensaver lock-enabled false	 2>/dev/null
                						gsettings set org.mate.screensaver idle-activation-enabled false	 2>/dev/null
                						gsettings set org.mate.screensaver lock_delay 0	 2>/dev/null
                				 echo " $screen_saver_running disabled" >> $logfile
                				 DISPLAY=:0  mate-screensaver  >/dev/null 2>&1 &
                				 ;;
                			 gnome-screensaver) echo 'gnome screen saver' >>$logfile
                			   gnome_screensaver-command -d >/dev/null 2>&1
                				 echo " $screen_saver_running disabled" >> $logfile
                			   ;;
                			 xscreensaver) echo 'xscreensaver running' | tee -a $logfile
                			   xsetting=$(grep -m1 'mode:' ~/.xscreensaver )
                				 if [ $(echo $xsetting | awk '{print $2}') != 'off' ]; then
                					 sed -i "s/$xsetting/mode: off/" "$HOME/.xscreensaver"
                					 echo " xscreensaver set to off" >> $logfile
                				 else
                				   echo " xscreensaver already disabled" >> $logfile
                				 fi
                			   ;;
                			 gsd-screensaver | gsd-screensaver-proxy)
                					setting=$(gsettings get org.gnome.desktop.screensaver lock-enabled 2>/dev/null)
                					setting1=$(gsettings get org.gnome.desktop.session idle-delay 2>/dev/null)
                					if [ "$setting. $setting1." != '. .' ]; then
                						if [ "$setting $setting1" != 'false uint32 0' ]; then
                							echo "disable screensaver via gsettings was $setting and $setting1" >> $logfile
                							gsettings set org.gnome.desktop.screensaver lock-enabled false
                							gsettings set org.gnome.desktop.screensaver idle-activation-enabled false
                							gsettings set org.gnome.desktop.session idle-delay 0
                						else
                							echo "gsettings screen saver already disabled" >> $logfile
                						fi
                					fi
                					;;
                			 *) echo "some other screensaver $screen_saver_running" found | tee -a $logfile
                			    echo "please configure it manually" | tee -a $logfile
                			   ;;
                		  esac
                		fi
                		if [ $(which gsettings | wc -l) == 1 ]; then
                			setting=$(gsettings get org.gnome.desktop.screensaver lock-enabled 2>/dev/null)
                			setting1=$(gsettings get org.gnome.desktop.session idle-delay 2>/dev/null)
                			if [ "$setting. $setting1." != '. .' ]; then
                				if [ "$setting $setting1" != 'false uint32 0' ]; then
                					echo "disable screensaver via gsettings was $setting and $setting1">> $logfile
                					gsettings set org.gnome.desktop.screensaver lock-enabled false
                					gsettings set org.gnome.desktop.screensaver idle-activation-enabled false
                					gsettings set org.gnome.desktop.session idle-delay 0
                				else
                					echo "gsettings screen saver already disabled" >> $logfile
                				fi
                			fi
                		fi
                		if [ -e "/etc/lightdm/lightdm.conf" ]; then
                		  # if screen saver NOT already disabled?
                			if [ $(grep 'xserver-command=X -s 0 -dpms' /etc/lightdm/lightdm.conf | wc -l) == 0 ]; then
                			  echo "disable screensaver via lightdm.conf" >> $logfile
                				sudo sed -i '/^\[Seat:/a xserver-command=X -s 0 -dpms' /etc/lightdm/lightdm.conf
                			else
                			  echo "screensaver via lightdm already disabled" >> $logfile
                			fi
                		fi
                		if [ -d "/etc/xdg/lxsession/LXDE-pi" ]; then
                		  currently_set=$(grep -m1 '\-dpms' /etc/xdg/lxsession/LXDE-pi/autostart)
                			if [ "$currently_set." == "." ]; then
                				echo "disable screensaver via lxsession" >> $logfile
                				# turn it off for the future
                				sudo su -c "echo -e '@xset s noblank\n@xset s off\n@xset -dpms' >> /etc/xdg/lxsession/LXDE-pi/autostart"
                				# turn it off now
                				export DISPLAY=:0; xset s noblank;xset s off;xset -dpms
                			else
                			  echo "lxsession screen saver already disabled" >> $logfile
                			fi
                		fi
                	fi
                fi
                echo " "
                if [ $pm2setup -eq $true ]; then
                	rmessage="pm2 start MagicMirror"
                else
                  rmessage="DISPLAY=:0 npm start"
                fi
                echo -e "\e[92mWe're ready! Run \e[1m\e[97m$rmessage\e[0m\e[92m from the ~/MagicMirror directory to start your MagicMirror.\e[0m" | tee -a $logfile
                
                echo " "
                echo " "
                
                date +"install completed - %a %b %e %H:%M:%S %Z %Y" >>$logfile
                pi@MagicMirror2:~ $ 
                
                
                S 1 Reply Last reply Reply Quote 0
                • S Do not disturb
                  sdetweil @bumrocks
                  last edited by

                  @bumrocks yes, the script is hard coded to MagicMirror

                  i ‘could’ allow a parm to change the folder name

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  B 1 Reply Last reply Reply Quote 0
                  • B Offline
                    bumrocks @sdetweil
                    last edited by

                    @sdetweil, I have made more time again. Thank you again for helping. But your last comment has me slightly confused. Here is what i “think”…

                    By changing the folder name as you suggested earlier, I sorta uninstalled it. At least made any script you directed me to, to not recognize it as already being there and therefore allowing the script to run as intended and install and check system as it normally would. But your last statement makes me think otherwise now. My confusion is why change a parameter? I really want to use your script as it is intended to do, install, check, etc as it is intended. I don’t want this to be any more difficult than it needs to be or for you to make special arrangements either as I am sure you have better things to do and you are opening yourself up for who knows what special requests in the future, lol.

                    Next, I am confused when reading the full return code that I posted above…It says…

                    echo -e "\e[91mSorry, your Raspberry Pi is not supported."
                    		echo -e "\e[91mPlease run MagicMirror on a Raspberry Pi 2 or 3."
                    

                    I have a Rasberry Pi 4. There are other things it states as issues but those are almost irrelevant until the script can perform as normal with the install. I have even gone as far as to try and find magicmirror in the “add/remove” software but after browsing and trying specific searches for it, I have come up empty. More confusion upon confusion.

                    I am at a loss as to what to do next outside of wiping this micro sdcard and starting over without the manual install…Please help! thank you!

                    S 2 Replies Last reply Reply Quote 0
                    • S Do not disturb
                      sdetweil @bumrocks
                      last edited by sdetweil

                      @bumrocks >Here is the full code as it is returned to me…

                      u are not supposed to SEE the code of the script… u just execute it

                      bash -c "… " means execute whatever is downloaded…

                      you just copy/paste that one line from my github repo and its all done

                      bash -c "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/raspberry.sh)"
                      

                      technically, the project (MagicMirror) says that it is ONLY supported on armv7l devices (pi 3 and 4).
                      my script allows you to install anyhow (if u want to try it anyhow)…
                      (I haven’t found anything it won’t run on, so its safe bet)
                      i didn’t update the message , but will correct it…
                      | edit: I have pushed the change for the run on 2/3/4 and supported on 2/3/4)

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • S Do not disturb
                        sdetweil @bumrocks
                        last edited by

                        @bumrocks the instructions on my repo say

                        to execute the install script, cut/paste this line into the terminal window on your device (I can't say PI, cause it works in a lot of other places too)
                        

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        B 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 2 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy