MagicMirror² v2.13.0 is available! For more information about this release, check out this topic.

Question: What is the process of modifying other people's module ?



  • Hi all,

    I have a question. Let’s say I want to modify some modules to fit my own need. What is the process ?

    Thanks


  • Project Sponsor

    @nagaculun either fork it on github or make copy of the module locally on your pie and start changing the code.



  • @nagaculun @broberg is right. If u think there is a possibility some of your changes might be useful to others, and you would be willing to contribute them, then forking the original module repo is the way to go.

    Then it is easy to submit a pull request to the source repo for including your changes



  • @sdetweil said in Question: What is the process of modifying other people’s module ?:

    Then it is easy to submit a pull request to the source repo for including your changes

    let me ask a question exactly to this point.
    Even I made some changes to an existin module for my convinience.
    Could be interesting to others also BUT I really doubt this will ever go in original module as it’s an language thing.

    Is here the way realy forking or still copy and make a link (how ever😵 ) to the original?
    Other way asked. Does it matter if I fork a module even the fork will stay in parallel?



  • @bdream in the case where I made a copy, and NOT a fork, i create a fork, rename my installed instance out of the way, then clone the fork from MY github userid, and then copy the files from the saved instance to the new instance, retest, then use git to save those (commit to local repository) and then push to the fork. then u can erase your saved instance

    now on the fork, others can try it out, as they can clone YOUR instance, instead of the original.

    you can then create a pull request to the original repository.

    your form does NOT stay in sync automatically with the original…

    YOU have to create a pull request FROM the original to your fork to get and merge updates…


Log in to reply