• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Question: What is the process of modifying other people's module ?

Scheduled Pinned Locked Moved Development
5 Posts 4 Posters 895 Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • N Offline
    nagaculun
    last edited by Oct 17, 2019, 5:14 AM

    Hi all,

    I have a question. Let’s say I want to modify some modules to fit my own need. What is the process ?

    Thanks

    B S 2 Replies Last reply Oct 17, 2019, 6:07 AM Reply Quote 0
    • B Offline
      broberg Project Sponsor @nagaculun
      last edited by Oct 17, 2019, 6:07 AM

      @nagaculun either fork it on github or make copy of the module locally on your pie and start changing the code.

      1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @nagaculun
        last edited by Oct 17, 2019, 1:03 PM

        @nagaculun @broberg is right. If u think there is a possibility some of your changes might be useful to others, and you would be willing to contribute them, then forking the original module repo is the way to go.

        Then it is easy to submit a pull request to the source repo for including your changes

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • B Offline
          bdream
          last edited by Oct 17, 2019, 1:48 PM

          @sdetweil said in Question: What is the process of modifying other people's module ?:

          Then it is easy to submit a pull request to the source repo for including your changes

          let me ask a question exactly to this point.
          Even I made some changes to an existin module for my convinience.
          Could be interesting to others also BUT I really doubt this will ever go in original module as it’s an language thing.

          Is here the way realy forking or still copy and make a link (how ever:dizzy_face: ) to the original?
          Other way asked. Does it matter if I fork a module even the fork will stay in parallel?

          –
          cheers, bdream

          S 1 Reply Last reply Oct 17, 2019, 1:53 PM Reply Quote 0
          • S Offline
            sdetweil @bdream
            last edited by Oct 17, 2019, 1:53 PM

            @bdream in the case where I made a copy, and NOT a fork, i create a fork, rename my installed instance out of the way, then clone the fork from MY github userid, and then copy the files from the saved instance to the new instance, retest, then use git to save those (commit to local repository) and then push to the fork. then u can erase your saved instance

            now on the fork, others can try it out, as they can clone YOUR instance, instead of the original.

            you can then create a pull request to the original repository.

            your form does NOT stay in sync automatically with the original…

            YOU have to create a pull request FROM the original to your fork to get and merge updates…

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            1 / 1
            • First post
              5/5
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy