MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-ResRobot - Public transport information for Sweden

    Scheduled Pinned Locked Moved Transport
    6 Posts 3 Posters 1.5k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @WillieGarvin
      last edited by sdetweil

      @WillieGarvin never mind… the data marked as ‘undefined’ is the ‘track number’
      I see in the repo this was changed recently (7 months)

      I’m guessing the api changed again

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      W 1 Reply Last reply Reply Quote 0
      • W Offline
        WillieGarvin @sdetweil
        last edited by

        @sdetweil Sorry, old picture.
        undefined is a reference to the track the departure is from and is not used in my location.
        Modification in MMM-ResRobot.js is adjusted so that it only appears IF there is a specified track for the train / bus.

        It should only be Linköping to the right column as it is the only “to:” the destination I am interested in and defined in to:the “to:”

        I changed the tours and got the same results.
        May be the API provider’s filter that fails.

        New image that matches better with the problem.

        0_1575720200632_MMM-ResRobot_01.png

        S 1 Reply Last reply Reply Quote 0
        • S Offline
          sdetweil @WillieGarvin
          last edited by

          @WillieGarvin looking at the code in node_helper, it only filters out the total number of entries and start
          of route time if requested

          the js code doesn’t filter at all

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          1 Reply Last reply Reply Quote 0
          • W Offline
            WillieGarvin
            last edited by

            Left the project a few hours.
            Had changed in MMM-ResRobot.js line 22 where the default settings were set. Entered my data there and now the variable to: works as it was supposed to.
            Only departures that match my destination are displayed.

            0_1575750507830_MMM-ResRobot_01.png

            1 Reply Last reply Reply Quote 0
            • AlvingerA Offline
              Alvinger
              last edited by

              @WillieGarvin,
              Thank you all for using my module! I know that it hasn’t been updated in a while as there has been no request for feature expansion apart from the TrackNo request seven months ago. The addition of that field was a bit of a hack on my part and it is not implemented in the best way, sorry for that.

              As you have found out there is no additional filtering done apart from matching to and from destination ids. The reason for this is that, for most use cases, setting the destination id should be enough. Of course, if the destination id is just a waypoint, the ultimate destination might be different.

              If you have request for new/changed functionality, do let me know.

              1 Reply Last reply Reply Quote 0
              • 1 / 1
              • First post
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy