MMM-COVID-19 (Deprecated)

lavolp3

@Sean I like it very much but my wife would kill me if I put this on the bathroom mirror! Would need a face recognition for that.
What I would find interesting are the daily cases of “new confirmed” vs “new recovered”. You think that would be able to be implemented?

A Former User

@lavolp3
In API, timeseries data could be derived also. So I think possible. Maybe I can add a line-graph for last 10 days with canvas too. But frankly says, I wish someone make it for me. Always I’m making modules by myself because nobody makes it for me before. Myself is very lazy. :)
Today, I have a prior work to finish, so in 2~3 days I’ll add that feature new confirmed and new recovered.

lavolp3

@Sean Can you give me a source for the time_series data?
Then I’ll try to add a graph via chart.js and send a PR

A Former User

@lavolp3
You can use https://github.com/Laeyoung/COVID-19-API
Or you can find several apis by googling

lavolp3

@Sean I’ve tried to call the timeseries link with the implemented XMLHTTPrequest but only get an incomplete answer (readyState 3, Status 200)
Any suggestions?

A Former User

@lavolp3
I’ll try and implement your requested feature in 1~2 days. Thanks for interesting. :)

lavolp3

@Sean working on it and not too far from finished in this branch
https://github.com/lavolp3/MMM-COVID-19/tree/timeseries

Source data is called and parsed to an array which can be used by the chart. This part is done
The chart however is not yet shown in the dom. Chart.js is always tricky for me since the dom object needs to be created first and then filled with the chart.
Also the many dom updates due the revolving regions does not help for me.

But I guess it’s a start.

A Former User

@lavolp3
I’m removing a dependency of API, Instead, data will be accessed from Original JohnsHopkins GitHub directly. So, can you wait a while till refactoring is finished? (1~2 days will be taken)

sdetweil

@lavolp3 said in MMM-COVID-19:

Chart.js is always tricky for me since the dom object needs to be created first and then filled with the chart.

It shouldn’t be that hard.
If the div doesn’t exist, create it
If u have data /new data to display, create the chart into that div, else leave it empty.

Update chart didn’t work for me very well. So I delete the prior when building the new chart.

lavolp3

@sdetweil you’re right. It gets more difficult if I do it in a rep I haven’t created. Need to find out the workflow first and sometimes crate workarounds. Every MM module developer has their own ways of creating update/call cycles.
However since I’m really new to JS this is all still quite challenging.