remotecompliments disappeared - please help

forjer

@sdetweil Also, is there a way to get my compliments2 to allow time splits at say 11:30 instead of just integer hours? Something like the following?

afternoonStartTime: 11:30,
afternoonEndTime: 13,

It would appear the complimentArray would need to be adjusted by changing “hour” to something else?

} else if (hour >= this.config.afternoonStartTime && hour < this.config.afternoonEndTime && this.config.compliments.hasOwnProperty("afternoon")) {
	compliments = this.config.compliments.afternoon.slice(0);

sdetweil

@forjer read the doc

u can have different remotefiles too

https://docs.magicmirror.builders/modules/compliments.html

sdetweil

@forjer if u need 10 time slots, then the compliments module would need changing as u might already have done. u should change your own copy, and then use that

from the modules folder
cp defaults/compliments mycompliments
have to change the module register at the top to be the same as the folder name u create on the copy

sdetweil

@forjer looks like the default time slots are hour based. so another reason to make your own

forjer

@sdetweil Thanks for all of you time and help. You are a wealth of knowledge.
I’ve only been digging into this thing for a few weeks and I’ve seen so many of your posts helping others. Kudos!

I like this kind of stuff, I just wish I had better core knowledge so I didn’t spend so much time looking stuff up and tinkering, but I guess that’s one way to learn.

I have gotten my custom “compliments2” module to work, but still only with integers for time. There’s got to be a simple way to change that. I’ll keep looking.

sdetweil

@forjer said in remotecompliments disappeared - please help:

but still only with integers for time.

what do u mean?

sdetweil

@forjer my son calls me all the time w questions. I don’t know much, but I know how to search, and can usually find an answer pretty quick.

I do it here too, all the time, writing code, working on install issues. trying to help w modules I don’t know.

I didn’t know we could run multiple compliments modules concurrently, but I figured it out looking at the code.

forjer

@sdetweil said in remotecompliments disappeared - please help:

@forjer said in remotecompliments disappeared - please help:

but still only with integers for time.

what do u mean?

I mean that by default, compliments only allows defining “morningStartTime” as 5, but I would like to be able to do is define it as 5:35.

sdetweil

@forjer so, allow the start/end time to be hh:mm

then check and split if contains ‘:’
make mins default to 00 if not

// make starttime always have minutes if specified use them, if not use 00
config.startTime=config.startTime.inclides(':')? config.startTime, config.startTime+':00'
and then split (split(':') and convert parts to numbers (parseInt())
var temp = config.startTime.split(':') 
temp[0] = hours
temp[1] = minutes

this.afternoonStartHour = parseInt(temp[0])
this.afternoonStartMinute = parseInt(temp[1])

repeat for all your time windows

then change the code to compare

might be able to use moment() before()/after() if u build a moment() value from the time slots.
I think moment has an isBetween()
https://momentjscom.readthedocs.io/en/latest/moment/05-query/06-is-between/

google is your friend

forjer

@sdetweil I will have to mess with that when I have more time.