remotecompliments disappeared - please help

[sdetweil]

@forjer sorry, I’ve run out of everything to look for. the error is gone now…

[forjer]

@sdetweil In my developer log it mentions “RemoteCompliments: ‘MODULE_DOM_CREATED’ received: null” and “module.js:199 MMM-RemoteCompliments is suspended.” Is that a clue? It just doesn’t make sense. I tested it yesterday morning by putting in a really long compliment just to see how it looked on the screen. I then reverted it back to a short compliment. Later in the morning I did a sudo apt-get update and a sudo apt-get upgradejust before setting up remote desktop, VNC and pitunnel. Those are the only other things that I can think of where I changed some stuff.

developers window

Load script: modules/MMM-RemoteCompliments//MMM-RemoteCompliments.js
module.js:513 Module registered: MMM-RemoteCompliments
loader.js:148 Bootstrapping module: MMM-RemoteCompliments
loader.js:176 Load script: modules/MMM-RemoteCompliments//scripts/jquery-3.3.1.min.js
loader.js:153 Scripts loaded for: MMM-RemoteCompliments
loader.js:155 Styles loaded for: MMM-RemoteCompliments
loader.js:157 Translations loaded for: MMM-RemoteCompliments
loader.js:195 Load stylesheet: css/custom.css
:8080/modules/default/clock//clock.js:46 Starting module: clock
main.js:508 All modules started!
:8080/modules/MMM-RemoteCompliments//MMM-RemoteCompliments.js:222 MMM-RemoteCompliments: 'MODULE_DOM_CREATED' received:  null
module.js:199 MMM-RemoteCompliments is suspended.

Are there any other (perhaps more stable) modules where I can display a custom message (compliment) depending on the time of day? I had about 10 compliments programmed to display at their specified time slots throughout the day. And I liked the ability to control / override them easily with my phone via Google Drive.

[sdetweil]

@forjer the code and comments

// Hide module on startup. 
			// If the module receives data, the module will reveal itself.
			self.hide(0);
			self.hidden = true;

which is reasonable, but it just reinforces no data.

sorry no idea on another module that does this other than the default compliments module with remotefile

[forjer]

@sdetweil Hmm…is there a simple way to hard code in a RemoteCompiment to force it to show? Just as a troubleshooting step to see it?

I guess I could consider the default compliments with remote file. Can I run a second default compliment module at the same time? Is it as simple as copying the folders and renaming them “compliments2” or something?

[sdetweil]

@forjer the default compliments module can be used multiple times without problem. you either pass the compliments as config parms or in a remotefile as config parm

[forjer]

@sdetweil So are you saying I can run two instances of compliments at the same time, shown in two different locations on the same display? And is this done by copying the compliments.js to make a “compliments2.js”?

[sdetweil]

@forjer yes, two instances, no need to copy the module

[forjer]

@sdetweil I’m sorry, I’m a little slow. And this is making my brain hurt. I really appreciate your patience with me.

How would this look in config.js? And how does it know which compliments go in what position of the MM?

What I’m after is a normal compliments module running in lower_third, and a second compliments module sliced into 10 time slots with a different set of compliments running in upper_third. I’ve just finished modifying the default compliments.js to get my 10 time slots and that seems to work, so I’m getting closer.

[sdetweil]

@forjer modifying?

no need to modify ( never modify module source code)

code two modules wherever u want.
put the compliments text in the config block in config.js

I am on my phone so everything but the actual compliments

{
     module:"compliments",
     position:"lower_third",
     config:{
           compliments:{
                 same as in defaults section of code
                 whatever  compliments for module 1
           }
           OR
            remotefile:"http://....... somefile on some server"
     }
},
{
     module:"compliments",
     position:"upper_third",
     config:{
           compliments:{
                 same as in defaults section of code   
                 whatever  compliments for module 2
            }
     }
}

[forjer]

@sdetweil Progress. So I saved a copy of my modified compliments.js into a compliments2 folder as compliments2.js and renamed module.register to compliments2. I then reverted my compliments.js back to original. I then added a compliments2 section into my config.js. And now I have two separate compliments running! I tried that a few hours ago but I must have done something wrong so it didn’t work.

In the way you coded it, would I be able to have the ability to run Module 1 with the default time slots (complimentArray) while Module 2 runs a different time slot schedule?

Now I think I’d like to get a remotefile set up but I’m guessing I’ll run into some issue with remotefile for my compliments2.

[forjer]

@sdetweil Also, is there a way to get my compliments2 to allow time splits at say 11:30 instead of just integer hours? Something like the following?

afternoonStartTime: 11:30,
afternoonEndTime: 13,

It would appear the complimentArray would need to be adjusted by changing “hour” to something else?

} else if (hour >= this.config.afternoonStartTime && hour < this.config.afternoonEndTime && this.config.compliments.hasOwnProperty("afternoon")) {
	compliments = this.config.compliments.afternoon.slice(0);

[sdetweil]

@forjer read the doc

u can have different remotefiles too

https://docs.magicmirror.builders/modules/compliments.html

[sdetweil]

@forjer if u need 10 time slots, then the compliments module would need changing as u might already have done. u should change your own copy, and then use that

from the modules folder
cp defaults/compliments mycompliments
have to change the module register at the top to be the same as the folder name u create on the copy

[sdetweil]

@forjer looks like the default time slots are hour based. so another reason to make your own

[forjer]

@sdetweil Thanks for all of you time and help. You are a wealth of knowledge.
I’ve only been digging into this thing for a few weeks and I’ve seen so many of your posts helping others. Kudos!

I like this kind of stuff, I just wish I had better core knowledge so I didn’t spend so much time looking stuff up and tinkering, but I guess that’s one way to learn.

I have gotten my custom “compliments2” module to work, but still only with integers for time. There’s got to be a simple way to change that. I’ll keep looking.

[sdetweil]

@forjer said in remotecompliments disappeared - please help:

but still only with integers for time.

what do u mean?

[sdetweil]

@forjer my son calls me all the time w questions. I don’t know much, but I know how to search, and can usually find an answer pretty quick.

I do it here too, all the time, writing code, working on install issues. trying to help w modules I don’t know.

I didn’t know we could run multiple compliments modules concurrently, but I figured it out looking at the code.

[forjer]

@sdetweil said in remotecompliments disappeared - please help:

@forjer said in remotecompliments disappeared - please help:

but still only with integers for time.

what do u mean?

I mean that by default, compliments only allows defining “morningStartTime” as 5, but I would like to be able to do is define it as 5:35.

[sdetweil]

@forjer so, allow the start/end time to be hh:mm

then check and split if contains ‘:’
make mins default to 00 if not

// make starttime always have minutes if specified use them, if not use 00
config.startTime=config.startTime.inclides(':')? config.startTime, config.startTime+':00'
and then split (split(':') and convert parts to numbers (parseInt())
var temp = config.startTime.split(':') 
temp[0] = hours
temp[1] = minutes

this.afternoonStartHour = parseInt(temp[0])
this.afternoonStartMinute = parseInt(temp[1])

repeat for all your time windows

then change the code to compare

might be able to use moment() before()/after() if u build a moment() value from the time slots.
I think moment has an isBetween()
https://momentjscom.readthedocs.io/en/latest/moment/05-query/06-is-between/

google is your friend

[forjer]

@sdetweil I will have to mess with that when I have more time.