Update notification not working

[tosti007]

I am not sure if I am the only one so I thought it would be better to open a topic here instead.
The problem is with the default updatenotification. After doing quite some testing I found out that there is quite a big problem.
In the node_helper.js function configureModules there is a loop that goes through all the modules that aren’t default ones. In this loop there is a variable made named git and it’s function getRemotes is called with some kind of callback function. The problem here is that that callback function is never called. This results in the simpleGits array to be empty and then the preformFetch doesn’t have much to work with.
Lastly the preformFetch isn’t declared properly inside the object. It currently is preformFetch() {//whatever}, and should be preformFetch: function () {//whatever}.
Is anyone able to reproduce this problem or is it just me (windows 10)?

TLDR; updatenotification > node_helper.js > lines 33-44 broken, someone fix?

[strawberry 3.141]

@tosti007 if you want and have the time you can compare it with my mobile module, this has pretty much the same functionality and works for me. Maybe you’ll find the issue.

[tosti007]

@strawberry-3.141 looked through your post and github page, to which module are you referring? (link? :) I had struggles finding it)

[strawberry 3.141]

@tosti007 it starts here https://github.com/fewieden/MMM-Mobile/blob/c0739ceb43f303af02886abcd560033acbbba4c4/node_helper.js#L67

[tosti007]

@strawberry-3.141 thank you! I will check it out :)

[nobita]

@strawberry-3.141 said in Update notification not working:

@tosti007 it starts here https://github.com/fewieden/MMM-Mobile/blob/c0739ceb43f303af02886abcd560033acbbba4c4/node_helper.js#L67

what is different MMM-Mobile VS phone_notification

[tosti007]

@nobita MMM-Mobile is for his app he is making