MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Development Branch -- MMM-Unsplash

    Scheduled Pinned Locked Moved Bug Hunt
    19 Posts 5 Posters 4.6k Views 5 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Do not disturb
      sdetweil @yk
      last edited by sdetweil

      @yk hm… looking at the code and testing that module, this line (44) fails

      	img1.src = obj.urls.custom
      

      as ‘custom’ doesn’t exist

      Screenshot at 2021-03-06 09-02-44.png

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      Y 1 Reply Last reply Reply Quote 0
      • Y Offline
        yk @sdetweil
        last edited by

        @sdetweil saw that. Love the fact that it worked just a few days ago. I have a funny feeling it’s between Unsplash API and new work in MM. I’m reading the API docs now. It’s a simple setup so hopefully a tweak shouldn’t be too tough.

        S 1 Reply Last reply Reply Quote 0
        • S Do not disturb
          sdetweil @yk
          last edited by

          @yk its not in MM… don’t you love coincidences??
          the api just didn’t return the data it used to return

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          Y 1 Reply Last reply Reply Quote 0
          • Y Offline
            yk @sdetweil
            last edited by

            @sdetweil hehe. Agreed. And now I have a decision to make. Hack it to work or rewrite. 😉

            S 1 Reply Last reply Reply Quote 0
            • S Do not disturb
              sdetweil @yk
              last edited by

              @yk well, how did the ‘custom’ image compare to one of the other choices? and can u force the other choice back to what custom was…

              should be only a couple lines of code…

              i checked my background image code modules and they are ok… (local files)

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              Y 1 Reply Last reply Reply Quote 0
              • Y Offline
                yk @sdetweil
                last edited by

                @sdetweil Fixed. It’s a change in the Unsplash API. obj.urls.custom is no longer an option returned in JSON. I changed “custom” to “raw” and it’s good.

                Lovely.

                BKeyportB 1 Reply Last reply Reply Quote 1
                • BKeyportB Offline
                  BKeyport Module Developer @yk
                  last edited by

                  … I should check mine and flip over to dev myself.

                  The "E" in "Javascript" stands for "Easy"

                  S 1 Reply Last reply Reply Quote 0
                  • S Do not disturb
                    sdetweil @BKeyport
                    last edited by

                    @bkeyport this problem had nothing to do with MM… just coincidence…(which I HATE!)

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    BKeyportB 1 Reply Last reply Reply Quote 0
                    • BKeyportB Offline
                      BKeyport Module Developer @sdetweil
                      last edited by

                      @sdetweil Yeah, I know, but it don’t hurt to check.

                      The "E" in "Javascript" stands for "Easy"

                      1 Reply Last reply Reply Quote 0
                      • D Offline
                        duxnobis
                        last edited by

                        @yk said in Development Branch -- MMM-Unsplash:

                        obj.urls.custom

                        for all out there as stupid as I am… :-) its this which has to be modified from .custom to .raw (row 130 in my WallberryTheme.js file).

                        from:
                        p.url = photoData.urls.custom;

                        to:
                        p.url = photoData.urls.raw;

                        Cheers and thanks for the hack mates!
                        Patrick

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy