MMM-Strava stopped updating

mumblebaj

@levon Hi. Apologies for the late replies. Time difference. Can you check when last the tokens.js file was touched? That file is updated every time it does a call out to get data. Else I would suggest maybe just doing a git pull and npm install in the MMM-Strava folder. From the above replies I can’t see anything else that could be going wrong though.

levon

@mumblebaj No apologies needed at all - I appreciate all the info/suggestions.

Looks like the file is up-to-date, though the file was last touched about 30 minutes ago, in the config file it says to be updated every 10 minutes, so perhaps that’s a bit odd?

pi@io:~/MagicMirror/modules/MMM-Strava $ ls -lrts
total 256
 24 -rw-r--r--  1 pi pi  23415 Jun  3 07:09 README.md
 16 -rw-r--r--  1 pi pi  15048 Jun  3 07:09 node_helper.js
 12 -rw-r--r--  1 pi pi  12257 Jun  3 07:09 MMM-Strava.js
  8 -rw-r--r--  1 pi pi   6408 Jun  3 07:09 MMM-Strava.css
  4 -rw-r--r--  1 pi pi   1099 Jun  3 07:09 LICENSE
  4 drwxr-xr-x  2 pi pi   4096 Jun  3 07:09 tests/
  4 drwxr-xr-x  2 pi pi   4096 Jun  3 07:09 templates/
  4 drwxr-xr-x  4 pi pi   4096 Jun  3 07:09 public/
  4 -rw-r--r--  1 pi pi   1604 Jun  3 07:09 package.json
  4 drwxr-xr-x  2 pi pi   4096 Jun  3 07:09 translations/
  4 drwxr-xr-x 57 pi pi   4096 Jun  3 07:10 node_modules/
164 -rw-r--r--  1 pi pi 166945 Jul 28 14:02 package-lock.json
  4 -rw-r--r--  1 pi pi   1034 Aug 11 15:40 tokens.json

levon

@mumblebaj Ok, so I did this:

pi@io:~/MagicMirror/modules/MMM-Strava $ git pull && npm install
From https://github.com/ianperrin/MMM-Strava
 * [new branch]      dependabot/npm_and_yarn/path-parse-1.0.7 -> origin/dependabot/npm_and_yarn/path-parse-1.0.7
Already up to date.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.3.2 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"arm"})

added 380 packages from 277 contributors and audited 435 packages in 42s

75 packages are looking for funding
  run `npm fund` for details

found 13 vulnerabilities (12 moderate, 1 high)
  run `npm audit fix` to fix them, or `npm audit` for details
pi@io:~/MagicMirror/modules/MMM-Strava $

I didn’t run any of the fixes, I looked at audit, but didn’t see anything that seemed related to Strava.

Should I be concerned that the package-lock.json time stamp is different from the other June 3 files when I initially installed this? In all other modules the file stamps have the same values.

The log seems to show this module working ok, trying to get data every 5 minutes (I made it shorter for testing) though the timestamp on the tokens.json file hasn’t changed from 15:40 today, now it’s over 2 hours since then.

pi@io:~/MagicMirror $ grep Strava nohup.out 
[11.08.2021 16:46.44.905] [LOG]   Check MagicMirror version for node helper 'MMM-Strava' - Minimum version: 2.2.0 - Current version: 2.16.0
[11.08.2021 16:46.44.910] [LOG]   Module helper loaded: MMM-Strava
[11.08.2021 16:46.45.936] [LOG]   Connecting socket for: MMM-Strava
[11.08.2021 16:46.45.937] [LOG]   Starting module helper: MMM-Strava
[11.08.2021 16:46.54.215] [LOG]   MMM-Strava: "Getting data for module_8_MMM-Strava"
[11.08.2021 16:46.54.227] [LOG]   MMM-Strava: "Getting athlete activities for module_8_MMM-Strava after 2021-01-01"
[11.08.2021 16:46.54.961] [INFO]  Checking git for module: MMM-Strava
[11.08.2021 16:46.58.455] [LOG]   MMM-Strava: "Summarising athlete activities for module_8_MMM-Strava"
[11.08.2021 16:51.54.275] [LOG]   MMM-Strava: "Getting data for module_8_MMM-Strava"
[11.08.2021 16:51.54.279] [LOG]   MMM-Strava: "Getting athlete activities for module_8_MMM-Strava after 2021-01-01"
[11.08.2021 16:51.55.648] [LOG]   MMM-Strava: "Summarising athlete activities for module_8_MMM-Strava"

I think I’m going to try updating the Strava module again based on the instruction on their github page. If that doesn’t work, perhaps I’ll just try nuking that directory and reinstalling it from scratch.

I’m just puzzled it stopped working.

sdetweil

@levon npm install updates the package-lock.json file. ( its the record of what is installed under MM)

mumblebaj

@levon I think check if it is successfully hitting the API on Strava. Check https://www.strava.com/settings/api.

Also check if the Authorization Callback Domain matches your MM IP.

levon

@mumblebaj Yes, it is doing that for sure, I had kept an eye on that.

I think I finally tracked down the problem, however I don’t understand why it broke. The problem is with one of the options in the config.js file. I had used mode “chart” successfully since early June (ie for almost 2 months) as it also gave me stats on walks too, but for some reason the updates stopped happening with this mode (rather than the default “table” mode)

If I comment out the mode, or explicitly specify the default mode of “table”, I get the correct stats for runs, but it ignores the walk (as documented, it will only do run, swim, ride in “table” mode)

I think I will open an issue with this.

I appreciate all of your help/suggestions. Perhaps the code author can shed some light on this.

mumblebaj

@levon Awesome. Glad you found the issue. The code uses the npm module strava-v3. It looks like the method used does not return walking.

levon

@mumblebaj Thank again for your help and everyone else. I definitely learned more about the software and how everything is connected. I’m sure that will come in handy down the line.

ianperrin

Hi all, sorry for the delayed response

@levon looking at the screen shot of your stats from the python module, the total number of activities you have logged this year exceeds 200. Whilst the module will continue to work (making api calls and updating the tokens file) only the first 200 activities are summarised in the chart.

There is an issue relating to this bug ion GitHub, but I’ve not had the time to delve deeper.

To confirm, can you set the period to “recent” and confirm the latest activities are included in the chart?