Electron Security Issues

mumblebaj

@sdetweil Yep, understood. node-fetch has also had some changes which could cause some issues in future. I am trying to see if I can fix the MMM-Hue module and it calls out to a bridge which sits on the local network and runs into this CORS issue. Other modules have the same issue. This is going to make module dev a bit difficult, but I am sure we will adapt. :smiling_face_with_sunglasses:

karsten13

@mumblebaj

the warnings are normal, see https://github.com/electron/electron/blob/main/docs/tutorial/security.md#electron-security-warnings and you can disable them

@sdetweil

I agree that https is a pain but I think we will be forced to use it

@mumblebaj

I am trying to see if I can fix the MMM-Hue module and it calls out to a bridge which sits on the local network and runs into this CORS issue.

I see no chance to do this in the module. I found a first (ugly) workaround and will post this in the other thread later …

mumblebaj

Thanks @karsten13. Will await your post there. I am rewriting the module but am running into all kinds of issues. It is ugly. :-(

mumblebaj

@sdetweil Have you seen these errors before? Mirror still starts though. I have just noticed it now as I usually start my mirror from the cron.

[04.01.2022 19:49.27.681] [LOG]   Connecting socket for: MMM-Remote-Control
[04.01.2022 19:49.27.686] [LOG]   Starting node helper for: MMM-Remote-Control
[04.01.2022 19:49.27.724] [LOG]   Connecting socket for: calendar
[04.01.2022 19:49.27.729] [LOG]   Starting node helper for: calendar
[04.01.2022 19:49.27.732] [LOG]   Sockets connected & modules started ...
[04.01.2022 19:49.29.057] [LOG]   Launching application.
[28306:0104/194931.715456:ERROR:viz_main_impl.cc(161)] Exiting GPU process due to errors during initialization
[04.01.2022 19:49.33.896] [ERROR] ERROR! Could not find main module js file for MagicMirror-backup-restore
[28425:0104/194936.968648:ERROR:viz_main_impl.cc(161)] Exiting GPU process due to errors during initialization
[28481:0104/194939.078132:ERROR:viz_main_impl.cc(161)] Exiting GPU process due to errors during initialization
[28499:0104/194939.733204:ERROR:sandbox_linux.cc(376)] InitializeSandbox() called with multiple threads in process gpu-process.

sdetweil

@mumblebaj looks like MagicMirror-backup-restore is in the modules folder… should be in the users root, as it’s not a MagicMirror ‘module’

mv ~/MagicMirror/modules/MagicMirror-backup-restore ~

mumblebaj

@sdetweil Thanks Sam. That sorted it.

bigschucks

Recently I have only started coding and therefore do not pay attention to security bugs at all. I hope that it is not interesting for anyone to hack into our computer.

sdetweil

@karsten13 see
https://therecord.media/chrome-will-limit-access-to-private-networks-citing-security-reasons/amp/

oh joy

mumblebaj

@sdetweil And so it begins. Modules like the MMM-Hue and others that talk to internal devices on the local network is going to become a problem.

karsten13

@sdetweil

didn’t know this but I’m not surprised …

When this limitation is live the modules must send the new header, we will see which of them are still maintained …