MMM-WeatherAlerts

croc_dad72

@Gjones93 Maybe I don’t understand how to get right api then? I went in and subscribed, created a new api in the api generator, and is still isn’t working? I was able to borrow someone else’s api key for a min and it worked?

Gjones93

@croc_dad72 I tried that lat and lon and I am seeing the winter weather advisory.

Let me ask this: For the other weather modules (e.g. forecast), are you setting an apiVersion parameter in your config file? If yes, to what?

Lastly, are you able to share your config layout for the MMM-WeatherAlerts module, minus your apiKey? I’m expecting something like this:

		{
			module: "MMM-WeatherAlerts",
			position: "top_right",
			header: "Weather Alerts",
			config: {
				lat: "42.4604",
				lon: "-71.3489",
				colored: true,
				alertTimeFormat: "absolute",
			}
		},

Gjones93

@JohnGalt unable to replicate this issue. I setup my computer as MagicMirror server and then I am able to access the server from my computer’s web-browser and from my raspberry pi acting as a client with both displays showing as expected.

Am I misunderstanding your current configuration? Did you happen to set the ‘alertDateFormat’ parameter in your configuration as well?

croc_dad72

@Gjones93 said in MMM-WeatherAlerts:

@croc_dad72 I tried that lat and lon and I am seeing the winter weather advisory.

Let me ask this: For the other weather modules (e.g. forecast), are you setting an apiVersion parameter in your config file? If yes, to what?

Lastly, are you able to share your config layout for the MMM-WeatherAlerts module, minus your apiKey? I’m expecting something like this:

Im just using the default weather from MM, and I have changed any of those parameters at all, just added my api key, and city id.

My config:

{ module: "MMM-WeatherAlerts",
      position: "top_right", // top_right
      header: "Weather Alerts",
      config: {
      // See 'Configuration options' for more information.
        lat: "42.4604",
        lon: "-71.3489",
        apiKey: "",
        colored: true
}
},

sdetweil

@croc_dad72 please use code block markers for config info

paste your text into the message editor,
select the text you just pasted
and hit the button above the editor that looks like </>

that module config is not from MagicMirror

that would be

{
        module:'weather'

croc_dad72

@sdetweil my apologies, thank you for fixing it!

croc_dad72

@Gjones93 Well it seems to be working now, I guess I just needed to give the api time to start working, thanks for all the help!

JohnGalt

@Gjones93 - I am unable to replicate this today, too. It appears to be working as designed today. [There is no active alert at my location, so I changed the lat/lon to the same location in Alaska as before, and a Winter Weather Advisory displays. Both the local and Alaska work on the display and when accessing via a browser at port 8080 on my desktop.] For completeness, no - I did not set or change alertDateFormat from the default in the config.js.

Related but separate query: Does the module take up any space or affect existing modules when it is not actively displaying an alert? I ask because I have several instances of the default weather module stacked in the top_right region, and this module appears to affect their placement.

Gjones93

@JohnGalt appreciate the update.

For the module interference while no alerts are active, good eye. This is caused by the default “margin-bottom” that MagicMirror gives to each module. The result is that when no alerts are visible, the module takes up no space, but its margin is still pushing surrounding modules to create the undesired effect that you observed.

I have a quick (slightly-hacky) solution. In your “custom.css” file, add the following:

.MMM-WeatherAlerts {
  margin-bottom: 0px;
}

That should clean up the impact on your default weather modules. The side effect of this is that when there are alerts active, they will be stacked more tightly on-top of one another. I will look and see if I can find a robust way of handling this styling issue so that the spacing is included when the alerts are active and the spacing is “off” when there are no alerts to show. The trick here is that the spacing (margin-bottom) is set by the main app, and not by my module so it may take some work to implement a good solution.

FYI, on my mirror I have the alert module at the bottom of my default weather modules so it avoids this issue all together. Just another option…

JohnGalt

@Gjones93 - Humm, this is interesting. Thanks for the update. While I might just try moving the alert module to the bottom of the stack of weather modules, the core issue I have with it is it appears to also hold on to horizontal real estate when not actively displaying an alert - with the effect of carrying all the modules in that region with it. In my case, I have the weather modules down the right side of the display, narrowed to 82% in custom.css. Sadly, when running your alerts module, I cannot get custom.css to narrow it using the same code, and it also pads out the other modules from the side of the monitor… FWIW, I also tried controlling the alert module width using an absolute number of pixels, but that also had no effect.

The weather css code follows:

.module.weather {
  background-color:rgba(255,255,255,0.1);
  border-radius:8px;
  padding:8px;
  text-align: left !important;
  width: 82%;
  max-width: 82%;
  min-width: 82%;
}