MMM-Hoymiles-Wifi

evroom

sounds like a new config parm so you don’t have to edit the file
(pass as a parameter on /hoymiles_data.py start)

Exactly!

I did change hoymiles_data.py to be able to refrain from hard-coding it:
python hoymiles_data.py --dtu_ip_address 192.168.178.114--debug
The next thing would be to pass the parameter(s) from the configuration (to be coded in the MMM-Hoymiles-Wifi.js file).

As I never made a module myself, I would need to find out how.

Any suggestions are much appreciated!

E.J.

sdetweil

@evroom put it in the modulename.js defaults section
i bet the config is already passed to the node helper which execs the python script.
yep

  this.sendSocketNotification("INIT", this.config)

then the user adds the property to the config.js module entry, as they are editing it anyhow

evroom

@SuVo

Hi, question,

do you live somewhere sunny ?

Could you try the run this and share the output ?

hoymiles-wifi --host 192.168.178.114 get-real-data-new

You’ll need to change the IP to the IP of your DTU.

E.J.

evroom

@sdetweil said in MMM-Hoymiles-Wifi:

i bet the config is already passed to the node helper which execs the python script.

Actually the python script is being executed via a shell script (in order to make it running using pm2).
I do not see anything in the node_helper.js file.

This is mainly due to the fact that the developer of the module used MMM-HTMLSnippet as basis and concentrated more on the data that he wanted to display.

The challenge is now to have everything running inside the module, without this ‘external’ stuff.
As all modules tend to do.

sdetweil

@evroom see my pythonPrint module for how to execute a python script

https://github.com/sdetweil/MMM-PythonPrint
you can also exec a shell script too

and launch pm2 to start/stop that shell script

schris88

@evroom said in MMM-Hoymiles-Wifi:

@sdetweil said in MMM-Hoymiles-Wifi:

i bet the config is already passed to the node helper which execs the python script.

Actually the python script is being executed via a shell script (in order to make it running using pm2).
I do not see anything in the node_helper.js file.

This is mainly due to the fact that the developer of the module used MMM-HTMLSnippet as basis and concentrated more on the data that he wanted to display.

The challenge is now to have everything running inside the module, without this ‘external’ stuff.
As all modules tend to do.

This is true, it´s a hacked proof of concept, nothing to be proud of at the moment :D

Not sure how much time I have for it till end of year, I can grant write access to anyone who´s willing to help.

evroom

@schris88 said in MMM-Hoymiles-Wifi:

This is true, it´s a hacked proof of concept, nothing to be proud of at the moment :D

Not sure how much time I have for it till end of year, I can grant write access to anyone who´s willing to help.

Not to worry. You sparked an idea.

I have some modifications ready (I forked it), but fighting with github to get it synced (github wants to delete all my modifications when I try).
Perhaps granting me access (evroom) wil make it easier.
Although it is not really the way to use github, I guess.

E.J.

sdetweil

@evroom

you fork
clone fork //git clone
make new branch // git checkout -b nane
make code changes
// this part multiple times
add to files to commit // git add filename
git commit
git push // to add to github fork
//

on github go to original repo source
create pull request // for origin to pull changes from your fork

if subsequent push to same branch, PR will be updated automatically

evroom

@sdetweil said in MMM-Hoymiles-Wifi:

git commit
git push // to add to github fork

I am stuck here.
Will open a new topic for it …

evroom

Hi there,

I made some major changes to the code and hopefully did all the GitHub stuff correct in order to allow persons interested to give it a (new) try.

https://github.com/schris88/MMM-Hoymiles-Wifi

There is still a lot to do (see ‘TODO’ in the README file), but I think the basis provided by Christian (@schris88) has been strengthened.

Best regards,

E.J.