Calendar moves right by 5 px every update

[emwtur]

@sdetweil Yes I did - but I have tried without

Checked the code and it led me to checking symbol settings - tried disabling all kinds of symbols -

sample cal

               {
                    name: "Google",
                    symbol: "google",
                    color: "#00F0F0",
                    maximumEntries: 4,
                    url: "webcal://127.0.0.1:8080/config/emwtur-gmail.ics",
                },

[sdetweil]

@emwtur but did u install custom symbols before?

the html seems like it is missing the symbol name

[emwtur]

no custom css’s anywhere…

Only thing, when I come to think of it - is that I have an old version of another calendar module …
I’ll uninstall that to check that it’s not causing any problems

[sdetweil]

@emwtur there is only one custom.css
css/custom.css where all style overrides go

[emwtur]

@sdetweil
Sorry if I’m not used to this forum messaging.

I have installed MM new - latest and greatest - after new year using the scripts at https://github.com/sdetweil/MagicMirror_scripts

your’s I believe :-)
I have not modified anything inside MM - only added a few modules - the same I had with my previos version - which was the penultimate release I think.
I have not touched any css files - god forbid - I am a backend dev cheating a little in react.js at work css always end up with !important and strange stuff

[sdetweil]

@emwtur is that cal entry the one with the html?

[emwtur]

@sdetweil No it was another calendar module showing a week view -

I was showing the html I get when I browse to the url of the machine showing the magic mirror - should be the same html that is shown on the mirror - I have the same problems in both anyway

I have removed the other calendar module and still have the problem

/P

[sdetweil]

@emwtur still, the symbol name is not being used

[emwtur]

@sdetweil

Doing the dirty fix :
round line 320 in calendars.js :

                            const symbols = this.symbolsForEvent(event);
                            symbols.forEach((s, index) => {

// const symbol = document.createElement(“span”);
// symbol.className = s;
// if (index > 0) {
// symbol.style.paddingLeft = “5px”;
// }
// symbolWrapper.appendChild(symbol);
});
eventWrapper.appendChild(symbolWrapper);

removes the issue for me - I assume the calculation goes wrong somehow - I tried to remove my different calendars one by one and it did not affect the “move right” so

For today - I’ll leave it at that - can’t tell if it’s parsing the calendar and thinking there are more and more symbols ?

[sdetweil]

@emwtur can you show the calendar configs? xxx out the urls

there was a fix in the area…

[emwtur]

@sdetweil
I’ll reinstall some stuff and try to remove all calendars I had and only use the one from the sample config and see how that goes.
Should point to something being wrong with my .ics files ( or how they are parsed, if it works
/P

[sdetweil]

@emwtur the fix was when there were multiple symbols

symbol:[x,y,z]

in the calendar specification

[emwtur]

@sdetweil
Yes I had multiple but tried to remove all of them - didn’t help.

Anyway having ONLY the cal from config.js.sample looks to work - having restored calendar.js to original

[emwtur]

@sdetweil
it has to do with multiple symbols.
looks like the bug can be reproduced using the cal setting from the sample file , just add another symbol and watch it move

{
		module: "calendar",
		header: "US Holidays",
		position: "top_left",
		config: {
			calendars: [
				{
					fetchInterval: 7 * 24 * 60 * 60 * 1000,
					symbol: ["calendar-check","google"]
					url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
				}
			]
		}
	},

[sdetweil]

@emwtur great!!! thsnks

[emwtur]

@sdetweil

Having single symbols is something I can live with - was just confused - it worked before updating…

thank YOU for great work with Magic Mirror.
regards
/Per-Eric

[sdetweil]

@emwtur ok, i made the change , so gotta figure out how i screwed that up

[sdetweil]

@emwtur want to try the fix

calendar.js , line 915

			if (p instanceof Array) {   // keep add brace, remove rest of line or // comment out
			 let temp=[]
			 p.forEach(name=>{temp.push(className +name)});
			 p = temp
			}                                                  
			else p = className + p;  // keep

[emwtur]

@sdetweil
Looks like it’s working with that fix - line numbers didn’t match so I had to think a little before applying - tested with multiple symbols on some cals and both symbols show and stay in place

/Per-Eric

[sdetweil]

@emwtur awesome!!!