MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    1. Home
    2. emwtur
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.
    E
    Offline
    • Profile
    • Following 0
    • Followers 0
    • Topics 1
    • Posts 12
    • Groups 0

    emwtur

    @emwtur

    0
    Reputation
    7
    Profile views
    12
    Posts
    0
    Followers
    0
    Following
    Joined
    Last Online

    emwtur Unfollow Follow

    Latest posts made by emwtur

    • RE: Calendar moves right by 5 px every update

      @sdetweil
      I’m happy sitting with modded code - I’ll have to stash it when next release comes in march or start fresh again.

      Thanks for your efforts once again !
      /Per-Eric

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil
      Looks like it’s working with that fix - line numbers didn’t match so I had to think a little before applying - tested with multiple symbols on some cals and both symbols show and stay in place

      /Per-Eric

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil

      Having single symbols is something I can live with - was just confused - it worked before updating…

      thank YOU for great work with Magic Mirror.
      regards
      /Per-Eric

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil
      it has to do with multiple symbols.
      looks like the bug can be reproduced using the cal setting from the sample file , just add another symbol and watch it move

      {
      		module: "calendar",
      		header: "US Holidays",
      		position: "top_left",
      		config: {
      			calendars: [
      				{
      					fetchInterval: 7 * 24 * 60 * 60 * 1000,
      					symbol: ["calendar-check","google"]
      					url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
      				}
      			]
      		}
      	},
      
      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil
      Yes I had multiple but tried to remove all of them - didn’t help.

      Anyway having ONLY the cal from config.js.sample looks to work - having restored calendar.js to original

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil
      I’ll reinstall some stuff and try to remove all calendars I had and only use the one from the sample config and see how that goes.
      Should point to something being wrong with my .ics files ( or how they are parsed, if it works
      /P

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil

      Doing the dirty fix :
      round line 320 in calendars.js :

                                  const symbols = this.symbolsForEvent(event);
                                  symbols.forEach((s, index) => {
      

      // const symbol = document.createElement(“span”);
      // symbol.className = s;
      // if (index > 0) {
      // symbol.style.paddingLeft = “5px”;
      // }
      // symbolWrapper.appendChild(symbol);
      });
      eventWrapper.appendChild(symbolWrapper);

      removes the issue for me - I assume the calculation goes wrong somehow - I tried to remove my different calendars one by one and it did not affect the “move right” so

      For today - I’ll leave it at that - can’t tell if it’s parsing the calendar and thinking there are more and more symbols ?

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil No it was another calendar module showing a week view -

      I was showing the html I get when I browse to the url of the machine showing the magic mirror - should be the same html that is shown on the mirror - I have the same problems in both anyway

      I have removed the other calendar module and still have the problem

      /P

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      @sdetweil
      Sorry if I’m not used to this forum messaging.

      I have installed MM new - latest and greatest - after new year using the scripts at https://github.com/sdetweil/MagicMirror_scripts

      your’s I believe :-)
      I have not modified anything inside MM - only added a few modules - the same I had with my previos version - which was the penultimate release I think.
      I have not touched any css files - god forbid - I am a backend dev cheating a little in react.js at work css always end up with !important and strange stuff

      posted in Bug Hunt
      E
      emwtur
    • RE: Calendar moves right by 5 px every update

      no custom css’s anywhere…

      Only thing, when I come to think of it - is that I have an old version of another calendar module …
      I’ll uninstall that to check that it’s not causing any problems

      posted in Bug Hunt
      E
      emwtur