MMM-Strava

MisterT

hI @ianperrin
I have another problem with MMM-Strava.
I use it with MMM-Pages and MMM-Pages indicator. When i place the module in the config.js MMM-Pages settings, the Rotation of MMM-Pages doesn’t work and i have a error on Magic mirror when i press CTRL+SHIFT+i.
See Thread below for mox explanations

MMM-Pages no rotate

Have you an idea?

ianperrin

@MisterT thanks for the report.

I don’t have any experience with MMM-Pages so will have to install it and take a look if I experience the same issues.

Have you any idea what might be causing it?

ianperrin

An updated BETA version of MMM-Strava is available which includes a chartType option to toggle between classic bar chart and a new radial histogram

Below is a sample config and screenshot - note the histogram will display in grayscale, colours can be achieved using custom.css

{
	module: "MMM-Strava",
	header: 'Strava Radial Chart',
	position: "top_right",
	config: {
		client_id: "xxxxx",
		client_secret: "xxxxx",
		mode: "chart",
		chartType: "radial",
		period: "ytd"
	}
},

Please report any comments/issues here, or on github

MisterT

@ianperrin thx for your reply, I’m the noob in .js but i tried to understand the problem and the report is about “toLowerCase”. In MMM-Strava.js, if i modify the three config lines witch contain the synthax “toLowercase”, the result on Magic Mirror is a rotation of MMM-Pages but a message “Undefined” for MMM-Strava

    this.config.mode = this.config.mode.toLowerCase();
    this.config.period = this.config.period.toLowerCase();
    this.config.chartType = this.config.chartType.toLowerCase();

hope these light explanations can help you :face_screaming_in_fear:

ianperrin

@MisterT can you post the modified versions of these lines which enabled MMM-pages to rotate, but caused the undefined error for MMM-Strava?

I’m also curious about the error you posted in the other thread as it seems to refer to a style sheet included by another module…

MisterT

@ianperrin i don’t know what i write and the meaning but if i modified these 2 lines (i don’t have the third line), i have MM rotation but undefined on MMM-Strava

   this.config.mode = this.config.mode.toLowerCase().mode;
  this.config.period = this.config.period.toLowerCase().period;

The other error in wallberry module is a css error but i don’t think that it’s the problem of rotation because MMM-pages works with this error

ianperrin

@MisterT I’ve just pushed an update to the module which may have fixed it. Can you update the module and let me know how it works out?

MisterT

@ianperrin, i update your module and…tada it works :thumbs_up: great job
MMM-Pages rotate and MMM Strava is visible
Everything is good now

I also try your other update about radial chart vizualisation and it’s great. I tested with year to date for bike and run and its’awesome. Just 2 remark:

In my opinion the radial gaphic it’s just a little too big and the graphic overlaps the other module.
I think we need informations about custom css in order to display colors about kilometers like for exemple:
less 10 km for running in a month : red color
from 10 to 30 km for running in a month: orange color
over 30 km for running in a month : green color

see you next time

ianperrin

@MisterT - Great to hear it’s working now 👍

ianperrin

@MisterT said in MMM-Strava:

the radial gaphic it’s just a little too big and the graphic overlaps the other module.
I’m working on making the chart size customisable - watch out for further updates

I think we need informations about custom css in order to display colors about kilometers like for exemple:
less 10 km for running in a month : red color
from 10 to 30 km for running in a month: orange color
over 30 km for running in a month : green color

I like the idea of colouring the bars based on a target. Will think about this one.

In the meantime, to customise the colours of each bar in the radial chart, add the following to the custom.css file in ~/MagicMirror/css.

.MMM-Strava svg path.bar.interval-1 {
  fill: #67b7dc;
}

.MMM-Strava svg path.bar.interval-2 {
  fill: #6794dc;
}

.MMM-Strava svg path.bar.interval-3 {
  fill: #6771dc;
}

.MMM-Strava svg path.bar.interval-4 {
  fill: #8067dc;
}

.MMM-Strava svg path.bar.interval-5 {
  fill: #a367dc;
}

.MMM-Strava svg path.bar.interval-6 {
  fill: #c767dc;
}

.MMM-Strava svg path.bar.interval-7 {
  fill: #dc67ce;
}

.MMM-Strava svg path.bar.interval-8 {
  fill: #dc67ab;
}

.MMM-Strava svg path.bar.interval-9 {
  fill: #dc6788;
}

.MMM-Strava svg path.bar.interval-10 {
  fill: #dc6967;
}

.MMM-Strava svg path.bar.interval-11 {
  fill: #dc8c67;
}

.MMM-Strava svg path.bar.interval-12 {
  fill: #dcaf67;
}

Note: As the radial chart is in beta, the css classes may be subject to change.