MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    [Enhancement] Translation system

    Scheduled Pinned Locked Moved Core System
    13 Posts 9 Posters 10.7k Views 9 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • qu1queQ Offline
      qu1que Project Sponsor @sdetweil
      last edited by

      @sdetweil

      Hi, I’ve just tried to create a new PR with a new translation for MM. I’ve followed your steps, and everything goes well, but the merge is blocked due to this message:

      Enforce Changelog / check (pull_request)

      Here is a link to my PR:

      https://github.com/MichMich/MagicMirror/pull/2491

      I’m a noob on github. What it would be the next step?

      Thanks in advance.

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @qu1que
        last edited by sdetweil

        @qu1que u needed to add the CHANGELOG.md
        describing your change

        on your same branch on pc edit the file, commit and push it. the existing PR will be updated and retested

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        qu1queQ 1 Reply Last reply Reply Quote 0
        • qu1queQ Offline
          qu1que Project Sponsor @sdetweil
          last edited by

          @sdetweil

          Yeah, it seems now is working. Thanks!

          1 Reply Last reply Reply Quote 0
          • 1
          • 2
          • 2 / 2
          • First post
            Last post
          Enjoying MagicMirror? Please consider a donation!
          MagicMirror created by Michael Teeuw.
          Forum managed by Sam, technical setup by Karsten.
          This forum is using NodeBB as its core | Contributors
          Contact | Privacy Policy