MMM-NEWS problem

stuartiannaylor

Sean I have it by the side of me and because I restart the server without need to restart the browser there is no aggregated duplicated articles.
It doesn’t happen and irrespective of who or what you are I have it by the side of me installed it without restart and others after with no duplicates as how could there be when the server has been restarted and the only remnants in cache have been dropped by a hard refresh.

Pfff enough of this as the universe is flat Sean, flat! Do you hear me!
Its a bug for those who have installed electron but if you use Chromium and do it my way its doesn’t matter.

A Former User

@stuartiannaylor
Of course, restarting wouldn’t make duplicated articles.
This module works nicely unless user REFRESHES it by manual.

I’m saying just my module is not designed for being refreshed. because REFRESHING will make my module to send socketNotification "START" to node_helper.js for scanning news source again unexpectedly. It is not related with which front browser is used, or which cache remains or not, or which mechanism is used for refreshing.

Its a bug for those who have installed electron but if you use Chromium and do it my way its doesn’t matter.

I don’t care how ppl use my module. So you can call it a bug. But usually people is using Electron as MM’s front and, usually there be no need to REFRESH MM by manual. A bug or not, I don’t care.

stuartiannaylor

Its not your module shaun but bugs elsewhere with freezing modules has some refreshing and then that cascades down to yours.

All I am saying is if you want a fix don’t go the electron way as because its part of the server it gets restarted with the server so you end up due to other modules periodically restarting with the effect that gives of flashing screens and desktop views.
What I am saying is that actually if you use chromium you don’t need to restart the heavy browser as you can keep that in view. You can restart the server and then do a hard refresh and because you start from a restart on the “Ready to go! Please point your browser to:8080” it can have no effect on any module.

That is it Sean and we shall not say argument but its you telling me that isn’t true when it is and I have your module MMM-news on a screen doing the above without restart and no duplication.
Its how I set it up because it has puzzled the hell out of me why with stateless browser / server technology you have lumped them into one?
As a roadmap you prob need to separate client / server or more users like this one will realise it works better when using chromium and not electron even though its only due to the way electron has been implemented.

I think your MMM-News module is the business and a large part of the way I did my setup was to make it work seamlessly with any module without needing browser restarts and it does that perfectly.
PS any chance when you bring the iframe of the full article up in an Iframe that you can enable and activate the DOM distiller so its in ‘Reader mode’?

A Former User

@stuartiannaylor

Its not your module shaun but bugs elsewhere with freezing modules has some refreshing and then that cascades down to yours.

I agree with you. but that’s not my fault.
However I always prefer to restart whole server/front than just to refresh only front.

Ideally to develop backend to work separated with frontend is a good behavior, but not so simple as expect. Ok, that is not an issue about difficulty but tiresome. This is not my job and MM is not commercial product. If someone has a problem on his MM, Just he can restart it. that is very simple solution.

By the way;
To fix(?) this bug(?) of this module is simple. Just inserting check routine for aggregator being already running or not on line 56 of node_helper.js. It will be just one-line solution. It could be a bullet-proof solution for this kind of issue.
But should I do that? (I’ll patch anyway)

But how about for my other modules? That might not be so simple for some modules of mine like this.(yes that will be entirely due to my lack of skills). Rather I want to eager to ppl to just RESTART when they have a problem with other modules instead my developing bullet-proof module. or at least, eager to use bug-less modules.

A Former User

@stuartiannaylor said in MMM-NEWS problem:

DOM distiller

For that, currently I have no idea yet. I’m not sure it is available on Electron also. (Lack of information)

A Former User

This post is deleted!

A Former User

@stuartiannaylor
Reader mode is added.

stuartiannaylor

Yeah that will be amazing will have to check it out.