MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    1. Home
    2. qistoph
    3. Posts
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.
    Q
    Offline
    • Profile
    • Following 0
    • Followers 0
    • Topics 3
    • Posts 17
    • Groups 0

    Posts

    Recent Best Controversial
    • RE: Test suite for MagicMirror²

      @roramirez what do you mean by “S.O”?

      posted in Upcoming Features
      Q
      qistoph
    • RE: Test suite for MagicMirror²

      Weird… don’t see anything wrong with your code and it also runs fine on my machine…

      Probably not really helpful, though, sorry

      posted in Upcoming Features
      Q
      qistoph
    • RE: Graph module

      Hi @feedparakeet,

      The MMM-dynchart was a sample used to show some ideas.

      A better example for you would be my Vitadock module:
      https://github.com/qistoph/MMM-vitadock

      Maybe you can use it to base your module on.

      If you could give a more detailed description of what you what to graph, I might be able to help you.

      posted in Requests
      Q
      qistoph
    • RE: Test suite for MagicMirror²

      @strawberry-3.141
      How about this?
      https://github.com/qistoph/MagicMirror/commit/406ae4e8c37cbf7e31c89f5341d7715bacbcf0d2

      			try {
      				expect(fileKeys).to.deep.equal(baseKeys);
      			} catch(e) {
      				if (e instanceof chai.AssertionError) {
      					this.skip();
      				} else {
      					throw e;
      				}
      			}
      
      posted in Upcoming Features
      Q
      qistoph
    • RE: Test suite for MagicMirror²

      Two commits I’ve worked on for the testing.

      1. Check keys in the translation files. Produces errors currently, so I’ve added .skip.
        https://github.com/qistoph/MagicMirror/commit/123392c54934e49a397d586c1fb8dbcc4cc5d12b

      2. To prevent loading app.js from corrupting the Mocha test environment, I suggest to execute the app.js in a virtual environment. This can also serve as an example for future test cases where code needs to be executed in the global namespace.
        https://github.com/qistoph/MagicMirror/commit/cd8bee1371ffc6cce7b7bf44f85cd03705e4c1bd

      Any thoughts before I submit a PR?

      posted in Upcoming Features
      Q
      qistoph
    • RE: Test suite for MagicMirror²

      Okay, just another brainfart.

      For the tests to run consistently and in such a way that we can test whatever is needed, we’re probably going to need a separate configuration file, maybe even a couple. If I’ve read the code correctly, we could set nodeIntegration in this config, without touching the code in MM to check for environment settings…

      This would be cleaner imho

      posted in Upcoming Features
      Q
      qistoph
    • RE: Test suite for MagicMirror²

      I agree, seeing MagicMirror become such a great success with lots of contributions and improvements is really nice. To keep the quality consistent and MagicMirror reliable with so many changes, it would really help to run tests automatically as much as possible.

      Maybe I’ll be able to work on some test-cases too, so feel free to include me in any communication. I’m also on Trello, so would be able to join there too.

      Good initiative!

      posted in Upcoming Features
      Q
      qistoph
    • 1
    • 2
    • 2 / 2