Read the statement by Michael Teeuw here.
Test suite for MagicMirror²
-
@morozgrafix Yes, I knowed is not more cleaner and repetitive but was the first proof of concept ;)
Good idea set default timeout. I added two new task in Trello board about you mentioned.
-
@roramirez I’ve played a little with test suite and added basic test for clock module. Then I realized that if we want to test different config options for a given module we may need to have to create multiple configs, which may be challenging with current tests directory organization.
Also I believe thatprocess.env.MM_CONFIG_FILE = "tests/confs/config_name.js"
line needs to be moved intobefore
step (seems to work there or it can go intobeforeEach
if needed). Otherwise when runningnpm run test:e2e
first config that gets picked up seems to persist throughout all of the tests and always used by theapp.js
.I was wondering if structure similar to this makes sense:
tests ├── configs │ ├── env.js │ └── modules │ │ └── clock │ │ │ └── clock_12hr.js │ │ │ └── clock_24hr.js │ │ │ └── clock_analog.js │ │ └── helloworld │ │ └── helloworld.js ├── e2e │ ├── env_spec.js │ └── modules │ ├── clock_spec.js │ └── helloworld_spec.js ├── functions │ └── compare-version_spec.js └── global_vars └── root_path.js
but this would involve changingI think that’s easily solved by just changing it toapp.use("/tests/confs", express.static(path.resolve(global.root_path + "/tests/confs")));
in theserver.js
to be somewhat dynamic and I’m not very familiar with express on how it can be done.app.use("/tests/configs", express.static(path.resolve(global.root_path + "/tests/configs")));
-
@morozgrafix Seem good sense going to a refactor of the structure.
I think we can take two way acord you mentioned.
1.- Include your test for clock module with new format for name and respective directories
2.- Do it the refactor to all tests that remain.I really like see how you resolve the multiples instances configuration in a one tests file.
-
@roramirez cool thanks. I have it all ready on my fork. Will submit PR for review.
-
Two commits I’ve worked on for the testing.
-
Check keys in the translation files. Produces errors currently, so I’ve added
.skip
.
https://github.com/qistoph/MagicMirror/commit/123392c54934e49a397d586c1fb8dbcc4cc5d12b -
To prevent loading
app.js
from corrupting the Mocha test environment, I suggest to execute theapp.js
in a virtual environment. This can also serve as an example for future test cases where code needs to be executed in theglobal
namespace.
https://github.com/qistoph/MagicMirror/commit/cd8bee1371ffc6cce7b7bf44f85cd03705e4c1bd
Any thoughts before I submit a PR?
-
-
@qistoph i like the idea of the sandbox
is there a way to just warn instead of error for missing translation keys?
-
@strawberry-3.141
How about this?
https://github.com/qistoph/MagicMirror/commit/406ae4e8c37cbf7e31c89f5341d7715bacbcf0d2try { expect(fileKeys).to.deep.equal(baseKeys); } catch(e) { if (e instanceof chai.AssertionError) { this.skip(); } else { throw e; } }
-
@qistoph Nice work. Related with your first point there a discussion about translations of JSON file.
https://github.com/MichMich/MagicMirror/pull/679 -
Hi Guys,
Today I’ve playing with test suite I something going me crazy
I create the follow test
https://github.com/roramirez/MagicMirror/commit/88f1f6bbd4fe6d7f3b9391993d207c7b9ebfb2e9Two check on same test case. On my enviroment ever but ever give me fail
smirror :: ~/MagicMirror ‹without-modules-test*› » ./node_modules/mocha/bin/mocha tests/e2e/without_modules.js Check configuration without modules ✓ Show the message create file config (83ms) 1) Show the message create file config 2 1 passing (6s) 1 failing 1) Check configuration without modules Show the message create file config 2: Error: An element could not be located on the page using the given search parameters ("#module_2_helloworld .module-content"). at elements("#module_2_helloworld .module-content") - getText.js:18:17 at execute(, "isLoading", , "require") - api.js:350:19
I pushed a sample for shared with you and these are passing on Travis
https://travis-ci.org/roramirez/MagicMirror/jobs/200521954Anybody can give me some light?
-
Weird… don’t see anything wrong with your code and it also runs fine on my machine…
Probably not really helpful, though, sorry