MMM-Lunartic

Anthony

@Mykle1 Hello there. I know that this is a very old topic but I want ask you something about a part of code you have inside this modules js and you have comment that we can copy paste this part of code into any module we want to control with voice. I mean this part of code:

  notificationReceived: function(notification, payload) {
        if (notification === 'HIDE_MOON') {
            this.hide(1000);
            //    this.updateDom(300);
        } else if (notification === 'SHOW_MOON') {
            this.show(1000);
            //   this.updateDom(300);
        }

    },

My question is that I must paste the code into the any module’s .js folder or somewhere else? If I paste it into the module’s .js folder won’t it be deleted after next update? Thank you in advance.

sdetweil

@Anthony he is not available currently. yes there is that risk. but you could fork the module repo, add that code to the module .js file , and submit a pull request back to the module author to get that code included.

Anthony

@sdetweil Thank you for your rapid reply. This a very good tool for me where I am not familiar with coding. I will do it. Thank you again.

DezHak

Super cool, def gonna check this out asap! Thanks for sharing.

BD0G

I need to update this module. Is there a preferred way to do so?

sdetweil

@BD0G said in MMM-Lunartic:

update this module.

updating ANY/EVERY module is the same

cd ~/MagicMirror/modules/module_name
git pull

if there is a package.json after git pull, do
npm install

BD0G

@sdetweil OK. Perfect. Been out of the game for a while so I might have known that but forgotten.

I ran into a commit changes or stash message.

pi@MagicMirror:~/MagicMirror/modules/MMM-Lunartic $ git pull
Updating c977e14…00655ab
error: Your local changes to the following files would be overwritten by merge:
MMM-Lunartic.js
Please commit your changes or stash them before you merge.
error: The following untracked working tree files would be overwritten by merge:
package.json
Please move or remove them before you merge.
Aborting

Just sudo git pull ? Then since it mentions the package.json do an npm install?

sdetweil

@BD0G someone has edited the source file…

NEVER do this, as your changes WILL be lost
ALL configuration is done in config.js

git diff

to detemine WHAT changes were made…

then to restore the file (and lose the changes)

git checkout MMM-Lunartic.js

same with package.json

BD0G

@sdetweil pi@MagicMirror:~/MagicMirror/modules/MMM-Lunartic $ git diff
diff --git a/MMM-Lunartic.js b/MMM-Lunartic.js
index 1520d0a…df2718c 100644
— a/MMM-Lunartic.js
+++ b/MMM-Lunartic.js
@@ -38,9 +38,7 @@ Module.register(“MMM-Lunartic”, {
es: “translations/es.json”,
de: “translations/de.json”,
sv: “translations/sv.json”,

```
       nl: "translations/nl.json",
```
```
       gl: "translations/gl.json",
```
```
       ca: "translations/ca.json",
```

       nl: "translations/nl.json"
   };

},

@@ -50,16 +48,16 @@ Module.register(“MMM-Lunartic”, {
requiresVersion: “2.1.0”,

         //  Set locale.

   this.url = "https://mykle.herokuapp.com/moon";

// this.url = this.getUrl();
:

sdetweil

@BD0G no idea how it could get that way

the author is away right now…

so, try this

git stash
to save the two files

then back to the original instructions