Calendar module: problem with moved Allday event (Google Calendar).

[evroom]

Hi,

I have an issue with the calendar module that occurs when you move an Allday event.
It can be recreated.
Perhaps someone has an idea where it goes wrong ?

Scenario:

Added an event ‘ThirdAllday event (date, repeating weekly)’, starting Nov 01.

–> On MMM: event seen on all Tuesdays, including this event on Tuesday Nov 08.

Moved one ‘ThirdAllday event (date, repeating weekly)’ event from Tuesday Nov 08 to Wednesday Nov 09.
Used click and drag.
‘Edit recurring event: This event’

On Google Calendar:

events seen on all Tuesdays, except the moved event (correct)
moved event not on Tuesday Nov 08 (correct).
moved event on Wednesday Nov 09 (correct).

On MMM:
events seen on all Tuesdays, including the moved event (false)
still the moved event on Tuesday Nov 08 (false).
NO moved event on Wednesday Nov 09 (false).

basic.ics on event creation:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20221101
DTEND;VALUE=DATE:20221102
RRULE:FREQ=WEEKLY;BYDAY=TU
DTSTAMP:20221026T100527Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
CREATED:20221026T100523Z
LAST-MODIFIED:20221026T100523Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT

basic.ics after moving 1 event:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20221109
DTEND;VALUE=DATE:20221110
DTSTAMP:20221026T100622Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
RECURRENCE-ID;VALUE=DATE:20221108
CREATED:20221026T100523Z
DESCRIPTION:
LAST-MODIFIED:20221026T100610Z
LOCATION:
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT
BEGIN:VEVENT

DTSTART;VALUE=DATE:20221101
DTEND;VALUE=DATE:20221102
RRULE:FREQ=WEEKLY;BYDAY=TU
DTSTAMP:20221026T100622Z
UID:1gfcnpgedl6tfe33rpebem95fm@google.com
CREATED:20221026T100523Z
LAST-MODIFIED:20221026T100523Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:ThirdAllday event (date\, repeating weekly)
TRANSP:TRANSPARENT
END:VEVENT

[sdetweil]

@evroom fun… will try to look at it later…

[sdetweil]

@evroom sorry for my delay, been busy here…

so, this is a problem i don’t know how to fix yet

by the time we see it, these two entries are collapsed into one

but a couple of problems. the repeating rule processor used by the calendar parser library we use has some problems with UTC dates
getting the new DAY with the OLD time., but only when there is a repeating rule using byday as your event does.
I have added code to correct for that… only when byday is found

BUT, in this case , its not wrong… take out the recurring event and it IS wrong… yikes…

now the second problem… we get passed the the recurrence date, BUT its the ORIGINAL date… 11/08 (1 week, tuesday) not the adjusted date (11/09, wednesday)… and I’m not sure how to tell the difference and its included in the byday entry data… and if so then the DATE is wrong…

now, looking at this second problem… the KEY is the old date, there is a new start/end … which we didn’t use… oops…
BUT… the date is CORRECT…

I think I might have a fix for this…

let me see how to get it to you

[evroom]

Sam,

Thanks a lot for diving into this.
I had massive Internet problems the last 4 weeks and could not get to it myself.

I am happy to modify a file or two to see if your fix works.
Just send me the filename(s) and what to modify and I will test it.

Btw, the Internet problems showed that when the calendar module cannot connect for some time, it just gives up and stalls.
When Internet is present again it does not try to connect again or does not put an effort to get calendar data (ics file).
But that is another topic.

Greetings,

E.J.

[sdetweil]

@evroom send me an email at this userid on gmail
and I will send back the file with instructions

[evroom]

@sdetweil

I applied your fixed calendarutils.js and ical.js files and it works like a charm now.
Many thanks for solving this, very much appreciated !!

E.J.

[sdetweil]

@evroom keep those files around

I opened this issue in node-ical
https://github.com/jens-maus/node-ical/issues/234

haven’t in MM yet (will need 2, one for MM and one for the node-ical update)