MMM-Remote-Control

rkorell

@sdetweil
Dear Sam,
thanks for this.

Until now I had avoided to upgrade with the thought “never touch a running system” …
Now it seems to be time for an upgrade - because I like MMM-Remote-Control.
@kristjanesperanto said: " at least node 22. I recommend version 24" - would one of these versions be installed by your current upgrade-script?

Than I would feel much better using your script than doing it manually …

As far as I remember i had some local (code) modifications in standard-weather module - this would prevent your upgrade-script from upgrading, as far as I remember.
Is this still true? And if yes: There was a “force” ooption in the script?

Thanks a lot for your work!

Warmest regards,
Ralf

sdetweil

@rkorell force was if you already had started installing MM and had the latest code… NOT if you have code changes

the upgrade will report if files are changed and allow you to save them in git. but generally its intended to remind you where you made changes and do something about it…

the node upgrade should not impact the running MM… (I say that with ’ quote marks, cause I am not sure…)

WHY do you NEED the RemoteControl update?? if you don’t NEED it, then don’t take it…

sdetweil

@rkorell said in MMM-Remote-Control:

would one of these versions be installed by your current upgrade-scrip

today it will install node 22.18.0
after Jan 1 (2 weeks away) it will install 22.21.1 (for the next release)

rkorell

@sdetweil
Good point!
Unfortunately I’ve already DONE the upgrade of remote-control - and now it doesn’t work anymore :-)

rkorell

@sdetweil
just ran a testrun of your upgrade script:

pi@MagicMirrorPi5:~/MagicMirror $ bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)"
update log will be in /home/pi/MagicMirror/installers/upgrade.log

doing test run = true, NO updates will be applied!

Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v22.18.0
Installed Node version: v20.18.1
Node should be upgraded.
Node.js upgrade defered, doing test run
Check current NPM installation ...
NPM currently installed. Checking version number.
Minimum npm version: V10.9.2
Installed npm version: V10.8.2
npm should be upgraded.
npm upgrade defered, doing test run  ...

saving custom.css
reverting to master branch from _fix_clipping, saving changed files
would restore file modules/default/weather/current.njk before switch back to master branch
would restore file package-lock.json before switch back to master branch
would restore file package.json before switch back to master branch
error: Your local changes to the following files would be overwritten by checkout:
        package-lock.json
        package.json
Please commit your changes or stash them before you switch branches.
Aborting
unable to change back to master branch, stopping execution

What does the last message mean?
“unable to change back to master branch, stopping execution”
What have I to do?

rkorell

@sdetweil
BTW: Do you know if it is possible to restore the “old” version from remote-control?
May THIS is the better option for me?

sdetweil

@rkorell can you tell me when old was? luckily this module uses tags for releases, so you could restore to one of the previous releases…

in the module folder do

git fetch --all --tags

then when we figure out which release to try, we can

git checkout <tag_name>

Release 3.2.1 was about 5 months ago.

rkorell

@sdetweil I’ve found V3.3.2 and just try "git checkout 1f451ce "

sdetweil

@rkorell if you pull the tags, you can use the tag name

git checkout v3.3.2

rkorell

@sdetweil
For some really strange reasons, neither

pi@MagicMirrorPi5:~/MagicMirror/modules/MMM-Remote-Control $ git fetch --all --tags
pi@MagicMirrorPi5:~/MagicMirror/modules/MMM-Remote-Control $ git fetch --tags

currently give any feedback…

So I’ve worked with the found git-hash:

git checkout 1f451ce

This at least worked and rolled back to V. 3.3.2.

Unfortunately some dependencies (package-lock.json ???) are not strict enough, so the rollback produces an error message:

[ERROR] Error when loading MMM-Remote-Control: require() of ES Module /home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/uuid/dist-node/index.js from /home/pi/MagicMirror/modules/MMM-Remote-Control/API/api.js not supported.

So I downgraded UUID:

cd ~/MagicMirror/modules/MMM-Remote-Control
npm install uuid@9.0.1
npm ci --omit=dev

With this module is running again.

From now on I’m in a in ‘detached HEAD’ state - but this seems OK.
Thanks for your time, effort and always great help!

Ralf