Please **review** my code, since I lack experience - mmm_velib, A module for bike sharing schemes in Europe

poutr

Thanks,

Yup, I have to clean this up. I get your fancy code over the switch case, that’s nice writing, I like it.

Anything else I should change, double proof or something ?

yawns

@strawberry-3.141
I shouldn’t go out with the dog. The long switch block was my first spot too, but you beat me to it :)

poutr

Ok, I have done the code clean up.

I use this call below to get the property value and not the propetry name, e.g. to get “Vélib’” and not “PARIS”. Am I right ?

var contractName = this.stationsData[0].contract_name.toUpperCase();
if (this.contractList.hasOwnProperty(contractName)) {
	marque = this.contractList[contractName];
}

If there is no other issues spotted, that’s great :)

Stupid question : how does one update his 3rd party module from github ? I used git clone https://github.com/Name/repo to install it on my mirror, but I don’t get how to update locally when the master on github is updated. Fetch failed me (no commit in common or something). I deleted and clone again but that’s so ugly.

yawns

Enter your module folder:

git pull origin master

poutr

@yawns ty, i will try it !

Brice

Suggestions :

format header correctly (class name = module-header)
remove station number from name
Great module btw !

poutr

@Brice Thanks!

ok for the format, will do that.

I am uneasy about removing the number from the name :

It comes as it from the JCDecaux server. Any parsing from my part would be under risk from future modifications.
The number is the ID, it feels more precise than a ‘name’.

I would need more users’ feedback for this point but with a grand total of one user ‘me’, I think I will let it like this, don’t you agree?

cheers