Test suite for MagicMirror²

qistoph

Two commits I’ve worked on for the testing.

Check keys in the translation files. Produces errors currently, so I’ve added .skip.
https://github.com/qistoph/MagicMirror/commit/123392c54934e49a397d586c1fb8dbcc4cc5d12b
To prevent loading app.js from corrupting the Mocha test environment, I suggest to execute the app.js in a virtual environment. This can also serve as an example for future test cases where code needs to be executed in the global namespace.
https://github.com/qistoph/MagicMirror/commit/cd8bee1371ffc6cce7b7bf44f85cd03705e4c1bd

Any thoughts before I submit a PR?

strawberry 3.141

@qistoph i like the idea of the sandbox

is there a way to just warn instead of error for missing translation keys?

qistoph

@strawberry-3.141
How about this?
https://github.com/qistoph/MagicMirror/commit/406ae4e8c37cbf7e31c89f5341d7715bacbcf0d2

			try {
				expect(fileKeys).to.deep.equal(baseKeys);
			} catch(e) {
				if (e instanceof chai.AssertionError) {
					this.skip();
				} else {
					throw e;
				}
			}

roramirez

@qistoph Nice work. Related with your first point there a discussion about translations of JSON file.
https://github.com/MichMich/MagicMirror/pull/679

roramirez

Hi Guys,

Today I’ve playing with test suite I something going me crazy

I create the follow test
https://github.com/roramirez/MagicMirror/commit/88f1f6bbd4fe6d7f3b9391993d207c7b9ebfb2e9

Two check on same test case. On my enviroment ever but ever give me fail

smirror :: ~/MagicMirror ‹without-modules-test*› » ./node_modules/mocha/bin/mocha tests/e2e/without_modules.js


  Check configuration without modules
    ✓ Show the message create file config (83ms)
    1) Show the message create file config 2


  1 passing (6s)
  1 failing

  1) Check configuration without modules Show the message create file config 2:
     Error: An element could not be located on the page using the given search parameters ("#module_2_helloworld .module-content").
      at elements("#module_2_helloworld .module-content") - getText.js:18:17
      at execute(, "isLoading", , "require") - api.js:350:19

I pushed a sample for shared with you and these are passing on Travis
https://travis-ci.org/roramirez/MagicMirror/jobs/200521954

Anybody can give me some light?

qistoph

Weird… don’t see anything wrong with your code and it also runs fine on my machine…

Probably not really helpful, though, sorry

roramirez

@qistoph I’ll test in other instance.

What S.O are you using?

qistoph

@roramirez what do you mean by “S.O”?

roramirez

@qistoph Sorry, Spanish acronymous. I mean Operating System.

On the another hand. The same commit is passed in Travis on my personal forked but in the main Mich’s repository failed.

https://travis-ci.org/roramirez/MagicMirror/builds/200750569 (Pass)
https://travis-ci.org/MichMich/MagicMirror/builds/200750793 (Fail)

It’s so weird.

qistoph

@roramirez my tests ran on Ubuntu.

The failed build you’re linking has timeouts. That’s the issue I added to the Trello board. We could increase the timeout a bit and see if it happens again in the next days.

Ask Mich to re-run the failed build, he should be able to click that option in Travis, being the owner of the project. See if that fails again. That resolved it for me before.