MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    I got sucked up into a magic mirror! (and need some help)

    Scheduled Pinned Locked Moved Development
    14 Posts 2 Posters 6.4k Views 2 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • E Offline
      E3V3A @raywo
      last edited by

      @raywo

      Your MMM look very nice and the code is indeed very clean, although quite different from what I’ve seen so far. However, I’m looking at this as an exercise, since it’s my first Module.

      So yes, using jquery + add-ons are definitely overkill, but has not yet been done before AFAICT. As you can see, in the demo.html, it makes doing fantastic tables using JSON a super breeze (obviously at the cost of external code and processing bloat). So since I hate making DOM from JS, I rather prefer using tools available, even if it means all this extra work and hair-pulling.

      I’ll soon update the repo code in the signature, once I get the table up.

      "Everything I do (here) is for free – altruism is the way!"
      MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

      R 1 Reply Last reply Reply Quote 0
      • R Offline
        raywo Module Developer @E3V3A
        last edited by

        @E3V3A Thank you! It was indeed my goal to write more readable code. Oftentimes javascript code is a mess and I thought I can do better.

        I’ve had a look at your code. It’s quite nice too. But of course it can be improved. ;)

        Maybe you should consider putting the methods processData, getData and scheduleUpdate in another class or at least in the node_helper.js file which is meant for exactly this purpose.

        E 1 Reply Last reply Reply Quote 0
        • E Offline
          E3V3A @raywo
          last edited by

          @raywo Hi Thank you fo r taking your time to look at this. I have now updated the code.
          It runs and I created a new loadTabulate function, that is supposed to do exactly the same as in the demo.html file…it returns, but nothing is displayed. I don’t know how to debug this, since there are no errors.

          Perhaps, I just doing this Tabulator inclusion all wrong. I have no idea how to proceed at this point.

          "Everything I do (here) is for free – altruism is the way!"
          MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

          R 1 Reply Last reply Reply Quote 0
          • R Offline
            raywo Module Developer @E3V3A
            last edited by raywo

            @E3V3A Your code looks nicer this way. Well done!

            What do you want to do next? Try to describe the goal. Maybe you should open an issue in GitHub where you describe what you want to do next. That way you will not forget what you wanted to achieve and others (like me) can see what you’re up to.

            BTW: I left some comments on your code on GitHub.

            E 1 Reply Last reply Reply Quote 0
            • E Offline
              E3V3A @raywo
              last edited by E3V3A

              @raywo Great! Thanks! I just answered…

              What’s next? Well, the table never get shown, so fixing that is next.
              Once all this demo works, it’s time to put it all into a module that is actually doing something.

              "Everything I do (here) is for free – altruism is the way!"
              MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

              R 1 Reply Last reply Reply Quote 0
              • R Offline
                raywo Module Developer @E3V3A
                last edited by raywo

                @E3V3A I have had a look at your code. I’ve opened a pull request. Have look!

                E 1 Reply Last reply Reply Quote 1
                • E Offline
                  E3V3A @raywo
                  last edited by

                  @raywo Hi Ray! Fantastic!! I just had a look at running your PR, and it works great! I also commented on the PR and the working Module will be pushed and ready in the next day or two. I was so close to giving up on this, so I am extremely grateful and in beer/food/wine debt to you. Thank you!

                  "Everything I do (here) is for free – altruism is the way!"
                  MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

                  R 1 Reply Last reply Reply Quote 1
                  • R Offline
                    raywo Module Developer @E3V3A
                    last edited by

                    @E3V3A I prefer wine. ;)

                    I’m looking forward to see your results.

                    E 1 Reply Last reply Reply Quote 0
                    • E Offline
                      E3V3A @raywo
                      last edited by

                      @raywo It’s now working and I’ve pushed all updates to repo. :)
                      My first module…that does nothing. :D

                      "Everything I do (here) is for free – altruism is the way!"
                      MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

                      1 Reply Last reply Reply Quote 1
                      • 1
                      • 2
                      • 1 / 2
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy